Cover @QuarkusTestResource & @QuarkusMainTest in QuarkusTestProfileAwareClassOrderer, skip @Nested, activate globally
#21610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `QuarkusTestProfileAwareClassOrderer` Resolves #20420
|
I haven't yet checked one aspect: Are the annotations evaluated when placed on a superclass of the respective test class? None of those has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20420 and also makes sure that everyone working on this repo has the same test order (which has also a small con, but mostly pros).
This will also activate the orderer in user projects, but you can opt out of that via a custom
junit-platform.properties(just tested this via a quickstart).For most users this should be just fine and is actually an improvement.
If we merge this, I'll add something to the migration guide.