Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute type-safe validation - validate namespace extension methods #20739

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Qute type-safe validation - validate namespace extension methods #20739

merged 1 commit into from
Oct 13, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 13, 2021

@mkouba
Qute type-safe validation - validate namespace extension methods
2cef352 
- also improve the error message if no resolver is found for a namespace
at runtime
- resolves quarkusio#20701
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Oct 13, 2021
@mkouba mkouba requested review from FroMage and gastaldi October 13, 2021 14:34
gastaldi
gastaldi approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a minor suggestion on using AssertJ for readability purposes

independent-projects/qute/core/src/test/java/io/quarkus/qute/NamespaceResolversTest.java Show resolved Hide resolved
@gastaldi gastaldi merged commit fbccba9 into quarkusio:main Oct 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 13, 2021
@aloubyansky aloubyansky modified the milestones: 2.5 - main, 2.4.0.Final Oct 18, 2021
@mkouba mkouba mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@FroMage FroMage Awaiting requested review from FroMage

Assignees
No one assigned
Labels
area/qute The template engine
Projects
None yet
Milestone
2.4.0.Final
Development

Successfully merging this pull request may close these issues.

Qute: namespace issue in included templates
3 participants
@mkouba @gastaldi @aloubyansky