Iterating over a list of enums generated by Qute Namespace Extensions no longer works

[wjglerum]

Describe the bug

We leverage Qute Namespace extensions to populate a list or dropdown with values from an enum. See https://quarkus.io/version/main/guides/qute-reference#namespace_extension_methods

public enum State {
    OPEN("Open"), CLOSED("Closed");

    private final String displayName;

    State(String displayName) {
        this.displayName = displayName;
    }

    public String getDisplayName() {
        return displayName;
    }
}

@TemplateExtension(namespace = "domain")
public static class DomainExtensions {

    static Set<State> states() {
        return EnumSet.allOf(State.class);
    }
}

<ul>
    {#for state in domain:states}
        <li>{state.displayName}</li>
    {/for}
</ul>

However this now results in an exception, also when we use checked templates.

[1] Incorrect expression found: {state.displayName}
	- property/method [displayName] not found on class [java.util.Set<nl.wjglerum.SomePage$State>] nor handled by an extension method
	- at page.qute.html:31
	at io.quarkus.qute.deployment.QuteProcessor.processTemplateErrors(QuteProcessor.java:186)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:887)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:277)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
	at java.base/java.lang.Thread.run(Thread.java:829)
	at org.jboss.threads.JBossThread.run(JBossThread.java:501)
	Suppressed: io.quarkus.qute.TemplateException: Incorrect expression found: {state.displayName}
	- property/method [displayName] not found on class [java.util.Set<nl.wjglerum.SomePage$State>] nor handled by an extension method
	- at page.qute.html:31
		at io.quarkus.qute.deployment.QuteProcessor.processTemplateErrors(QuteProcessor.java:166)
		... 11 more

It does work correctly when you just want to render the enums, but as soon as you call a property from the enum it fails. It looks like Qute incorrectly tries to find this (virtual) method on the Set or List instance instead of the enum in the collection.

This used to work up until version 2.4.0.CR1 but just failed on the latest snapshot build from the main branch.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

Sample project:
quarkus-qute-enum.zip

[quarkus-bot]

/cc @mkouba

[wjglerum]

Also seems to fail with 2.4.0.Final

[mkouba]

Hi @wjglerum, I'll take a closer look tomorrow. But I believe that previously those expressions were not validated at all (we did not validate namespace expressions until recently). This PR is related.

[wjglerum]

Hi @wjglerum, I'll take a closer look tomorrow. But I believe that previously those expressions were not validated at all (we did not validate namespace expressions until recently). This PR is related.

Thanks for the update 👍

[mkouba]

@wjglerum #21028 should fix the problem. It would be great if you could give it a try..

[wjglerum]

@wjglerum #21028 should fix the problem. It would be great if you could give it a try..

Just checked it out locally and seems to work again, thanks again for the quick response!