-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump guava from 30.1.1-jre to 31.0.1-jre #20641
Bump guava from 30.1.1-jre to 31.0.1-jre #20641
Conversation
Bumps [guava](https://github.com/google/guava) from 30.1.1-jre to 31.0.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog doesn't mention any breaking changes. LGTM!
I just remembered #20473 (comment) @aloubyansky isn't it actually a bit strange that this is covered by dependabot given that it has to stay aligned? |
The important dependency branch for bootstrap is
But we actually overrode the original Guava version, which was
I guess we overrode it because Guava is a popular library and it would make sense to include a more recent version of it in the
But that's in the tests. There are also Kotlin tests that have dependency on Guava. I guess, we can approve the upgrade, as long as the tests pass. |
I'll close this one though, given that there are conflicts now. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
@aloubyansky so you want to wait for the next update? |
It looks like it was safe, so I wouldn't mind the upgrade. If you would like to re-open, please go ahead @famod |
Bumps guava from 30.1.1-jre to 31.0.1-jre.
Release notes
Sourced from guava's releases.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)