Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Guava from 30.1.1 to 31.0.1 #20473

Closed
wants to merge 1 commit into from
Closed

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Sep 30, 2021

No description provided.

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Sep 30, 2021
@@ -95,7 +95,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>30.1.1-jre</version>
<version>31.0.1-jre</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can please you check whether that version can be removed?

@famod famod requested a review from aloubyansky September 30, 2021 11:03
@famod
Copy link
Member

famod commented Sep 30, 2021

@aloubyansky not sure we should bump this individually? Seems this should be in line with some other bootstrap deps?

@aloubyansky
Copy link
Member

How critical this update is?

@nastra
Copy link
Contributor Author

nastra commented Sep 30, 2021

How critical this update is?

It's not critical at all. Just figured it's worth updating now that there's a new version

@aloubyansky
Copy link
Member

Thanks for the info @nastra Given that guava's version is primarily dictated by the thirdparty libraries Quarkus bootstrap depends on, as @famod said, we should not update it on its own unless there is a critical issue it fixes. I'll close this PR for now. Thanks for taking care though.

@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants