Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved SmallRyeGraphQLConfigMapping to the runtime dependency #20602

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

radcortez
Copy link
Member

@michalszynkiewicz
Copy link
Member

we move it because otherwise the mapping can only be applied in the build time?

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can later separate this into two, because some does work on build time.

@radcortez
Copy link
Member Author

Because there are configurations that are being applied only at runtime. Buf it all configurations are actually build time and we can apply them in some way, then we don't actually need to move the interceptor to the runtime dependency.

@radcortez
Copy link
Member Author

I additionally moved SmallRyeGraphQLConfig to the runtime dependency and to BUILD_AND_RUN_TIME_FIXED. This will be a middle step until we figure out what needs to go to each phase.

This will also allow fixing the issue discovered by #20590

@geoand
Copy link
Contributor

geoand commented Oct 11, 2021

Should this be merged? If so, please do so soon in order to get it into 2.4.0.CR1.
Furthermore, should it be backported to 2.3?

@phillip-kruger phillip-kruger merged commit d2d1ca2 into quarkusio:main Oct 11, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 11, 2021
@gsmet gsmet modified the milestones: 2.4.0.CR1, 2.3.1.Final Oct 18, 2021
@radcortez radcortez deleted the fix-20494 branch November 22, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphql Quarkus properties not working
5 participants