Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only record config properties coming from ConfigSources #20590

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

radcortez
Copy link
Member

No description provided.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 868d740

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: integration-tests/devmode 

📦 integration-tests/devmode

Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:test-compile-custom (test-compile) on project quarkus-integration-test-devmode: protoc did not exit cleanly. Review output for more information.

@michalszynkiewicz
Copy link
Member

@radcortez can you rebase the change?

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 868d740

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
MicroProfile TCKs Tests Verify Failures Logs Raw logs
Native Tests - Misc3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: core/test-extension/deployment extensions/resteasy-reactive/rest-client-reactive/deployment extensions/smallrye-graphql/deployment and 1 more
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 11 more

📦 core/test-extension/deployment

io.quarkus.config.BuildTimeConfigTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.extest.deployment.MapBuildTimeConfigBuildStep#validate threw an exception: java.lang.AssertionError

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.LegacyConfigurationTest.configurationShouldBeLoaded line 31 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testBusinessError line 52 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testSystemError line 75 - More details - Source on GitHub

java.lang.AssertionError: 
2 expectations failed.
Response body doesn't match expectation.

📦 integration-tests/oidc

io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: core/test-extension/deployment extensions/resteasy-reactive/rest-client-reactive/deployment extensions/smallrye-graphql/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 11 more

📦 core/test-extension/deployment

io.quarkus.config.BuildTimeConfigTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.extest.deployment.MapBuildTimeConfigBuildStep#validate threw an exception: java.lang.AssertionError

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.LegacyConfigurationTest.configurationShouldBeLoaded line 31 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testBusinessError line 52 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testSystemError line 75 - More details - Source on GitHub

java.lang.AssertionError: 
2 expectations failed.
Response body doesn't match expectation.

⚙️ JVM Tests - JDK 17 #

- Failing: core/test-extension/deployment extensions/hibernate-orm/deployment extensions/resteasy-reactive/rest-client-reactive/deployment and 1 more
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 91 more

📦 core/test-extension/deployment

io.quarkus.config.BuildTimeConfigTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.extest.deployment.MapBuildTimeConfigBuildStep#validate threw an exception: java.lang.AssertionError

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.transaction.UserTransactionLifecycleTest. - More details - Source on GitHub

java.lang.AssertionError: 

Expecting empty but was: ["Thread Thread[vert.x-eventloop-thread-1,5,main] has been blocked for 2533 ms, time limit is 2000 ms"]

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.LegacyConfigurationTest.configurationShouldBeLoaded line 31 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

📦 integration-tests/oidc

io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-opentracing/base 
! Skipped: tcks/microprofile-opentracing/rest-client 

📦 tcks/microprofile-opentracing/base

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testAnnotationException - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testAnnotations - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testAsyncLocalSpan - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testError - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testException - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testLocalSpanHasParent - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testMultithreadedNestedSpans - More details - Source on GitHub

java.lang.AssertionError: 
expected [  {
    TestSpan: "{ operationName: GET:/testServices/nested, tags: [component=jaxrs, http.method=GET, http.status_code=200, http.url=http://localhost:8081/rest/testServices/nested?nestDepth=1&nestBreadth=2&async=false&data=1&failNest=false, span.kind=server], logEntries: []}",

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testMultithreadedNestedSpansAsync - More details - Source on GitHub

java.lang.AssertionError: 
expected [  {
    TestSpan: "{ operationName: GET:/testServices/nested, tags: [component=jaxrs, http.method=GET, http.status_code=200, http.url=http://localhost:8081/rest/testServices/nested?nestDepth=1&nestBreadth=2&async=true&data=101&failNest=false, span.kind=server], logEntries: []}",

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testNestedSpans - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testNestedSpansWithClientFailure - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testStandardTags - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testTwoSameParams line 178 - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingHTTPPathNameTests.testWildcard line 141 - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
  {

org.eclipse.microprofile.opentracing.tck.OpenTracingSkipPatternTests.testExplicitlyTraced line 127 - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
]

org.eclipse.microprofile.opentracing.tck.OpenTracingSkipPatternTests.testSkipFoo line 101 - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
]

org.eclipse.microprofile.opentracing.tck.OpenTracingSkipPatternTests.testSkipFooBar line 114 - More details - Source on GitHub

java.lang.AssertionError: 
expected [[
]

org.eclipse.microprofile.opentracing.tck.OpenTracingSkipPatternTests.testSkipSimple line 84 - More details - Source on GitHub

java.lang.AssertionError: Expected HTTP response code 204 but received 200; Response: 
	at org.testng.Assert.fail(Assert.java:96)
	at org.eclipse.microprofile.opentracing.tck.OpenTracingBaseTests.executeRemoteWebServiceRaw(OpenTracingBaseTests.java:163)

⚙️ Native Tests - Misc3 #

- Failing: integration-tests/smallrye-graphql 

📦 integration-tests/smallrye-graphql

io.quarkus.it.smallrye.graphql.GraphQLAndFaultToleranceIT.testGraphQLAndFaultToleranceTogether - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path errors[0].message doesn't match.

@michalszynkiewicz
Copy link
Member

hmm... there's quite a lot of failures that I haven't seen before.

Copy link
Member

@michalszynkiewicz michalszynkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the failures need to be investigated before merging

@radcortez
Copy link
Member Author

I think the failures need to be investigated before merging

Yes, maybe the change broke something else. Let me check.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building bef3a20

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
Native Tests - Misc3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/smallrye-graphql/deployment integration-tests/oidc 
! Skipped: docs extensions/smallrye-graphql-client/deployment integration-tests/hibernate-orm-graphql-panache and 2 more

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testBusinessError line 52 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testSystemError line 75 - More details - Source on GitHub

java.lang.AssertionError: 
2 expectations failed.
Response body doesn't match expectation.

📦 integration-tests/oidc

io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/smallrye-graphql/deployment 
! Skipped: docs extensions/smallrye-graphql-client/deployment integration-tests/hibernate-orm-graphql-panache and 2 more

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testBusinessError line 52 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testSystemError line 75 - More details - Source on GitHub

java.lang.AssertionError: 
2 expectations failed.
Response body doesn't match expectation.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-graphql/deployment extensions/smallrye-reactive-messaging-kafka/deployment integration-tests/oidc 
! Skipped: docs extensions/smallrye-graphql-client/deployment integration-tests/hibernate-orm-graphql-panache and 6 more

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testBusinessError line 52 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

io.quarkus.smallrye.graphql.deployment.GraphQLConfigMappingTest.testSystemError line 75 - More details - Source on GitHub

java.lang.AssertionError: 
2 expectations failed.
Response body doesn't match expectation.

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

📦 integration-tests/oidc

io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ Native Tests - Misc3 #

- Failing: integration-tests/smallrye-graphql 

📦 integration-tests/smallrye-graphql

io.quarkus.it.smallrye.graphql.GraphQLAndFaultToleranceIT.testGraphQLAndFaultToleranceTogether - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path errors[0].message doesn't match.

@radcortez
Copy link
Member Author

This is going to require #20494.

@michalszynkiewicz
Copy link
Member

@radcortez so with https://github.com/quarkusio/quarkus/pull/20602/files the tests are passing?

@radcortez
Copy link
Member Author

@radcortez so with https://github.com/quarkusio/quarkus/pull/20602/files the tests are passing?

Not exactly. The change that I did here uncovered an issue with GraphQL, that is related to #20494. GraphQL is also using an interceptor to relocate some properties, but only for build time (when some of the properties are runtime). Because we removed here the recording of interceptor properties, these keys are not recorded, but they are also not reread on runtime because the GraphQL configuration is set up to be build-time only.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 11, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building a65d922

Status Name Step Failures Logs Raw logs
Native Tests - Data1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Data1 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers 

📦 integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers

io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testGetFruitsDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <200> but was <500>.

io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testAddDeleteDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testPostFruitDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testGetFruitsTenantMycompany - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <200> but was <500>.

io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testUpdateFruitDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <201> but was <500>.

@michalszynkiewicz michalszynkiewicz merged commit 5bfeb6f into quarkusio:main Oct 15, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 15, 2021
@michalszynkiewicz
Copy link
Member

I think it should be backported to 2.4, @radcortez is there any other related PR that has to be backported too?

@TomasHofman
Copy link
Contributor

+1 on backport

@TomasHofman
Copy link
Contributor

Reasoning for triage:

Without this change, subsystems that use MP Config interceptors (like the FallbackConfigSourceInterceptor) can see wrong configuration values under some circumstances. Specifically some values registered during build time are not correctly overwritten by runtime config.

@radcortez
Copy link
Member Author

I think it should be backported to 2.4, @radcortez is there any other related PR that has to be backported too?

Yes. It requires #20494.

@michalszynkiewicz
Copy link
Member

it seems #20494 is already in 2.3.x so this one is good to backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants