Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filter to file module-info.class #20370

Conversation

netodevel
Copy link
Contributor

Issue: #20333

Removes log of module-info.class files duplicated between libs.

@Sanne,
How did you build the module: quarkus-integration-test-main ?
I'm trying to test the code above but I can't see these warning logs
how am i trying:
mvn verify -f integration-tests

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 24, 2021

Failing Jobs - Building 251542a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectGradleTest.testExtensionList line 187 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectGradleTest.testCreateAppDefaults line 46 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40)

@@ -393,8 +393,10 @@ private void buildUberJar0(CurateOutcomeBuildItem curateOutcomeBuildItem,
for (Map.Entry<String, Set<AppDependency>> entry : duplicateCatcher.entrySet()) {
if (entry.getValue().size() > 1) {
if (explained.add(entry.getValue())) {
log.warn("Dependencies with duplicate files detected. The dependencies " + entry.getValue()
+ " contain duplicate files, e.g. " + entry.getKey());
if (!"module-info.class".endsWith(entry.getKey())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@netodevel netodevel Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet,

I didn't add it there because it would have to be dynamic and IGNORED_ENTRIES there seems to be too static.

e. g:

META-INF/versions/{param_dynamic}/module-info.class
META-INF/versions/9/module-info.class
META-INF/versions/11/module-info.class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet, wdyt?
I couldn't think of anything better.

Copy link

@devprojectsme devprojectsme Dec 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netodevel,@gsmet - sorry to bother, but I guess you have turned it the other way around:

instead of

if (!entry.getKey().endsWith("module-info.class"))

you have written:

if (!"module-info.class".endsWith(entry.getKey()))

which hardly ever would be the case, or?

Have found it still written the same way in the 2.6.1.Final

@aloubyansky aloubyansky merged commit 2cc702a into quarkusio:main Oct 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 8, 2021
@Sanne
Copy link
Member

Sanne commented Oct 20, 2021

Fixes #20333

@devprojectsme
Copy link

Sorry to bother, even though it has already been merged and may be I am missing something, but I guess there is a problem - #20370 (comment)

@gsmet
Copy link
Member

gsmet commented Dec 29, 2021

Hmmm, you're right, I don't know how we missed it :/. Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants