-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds filter to file module-info.class #20370
Adds filter to file module-info.class #20370
Conversation
Failing Jobs - Building 251542a
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: devtools/cli
📦 devtools/cli✖
✖
|
@@ -393,8 +393,10 @@ private void buildUberJar0(CurateOutcomeBuildItem curateOutcomeBuildItem, | |||
for (Map.Entry<String, Set<AppDependency>> entry : duplicateCatcher.entrySet()) { | |||
if (entry.getValue().size() > 1) { | |||
if (explained.add(entry.getValue())) { | |||
log.warn("Dependencies with duplicate files detected. The dependencies " + entry.getValue() | |||
+ " contain duplicate files, e.g. " + entry.getKey()); | |||
if (!"module-info.class".endsWith(entry.getKey())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would probably be better to add it here and ignore it altogether: https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java#L105
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add it there because it would have to be dynamic and IGNORED_ENTRIES
there seems to be too static.
e. g:
META-INF/versions/{param_dynamic}/module-info.class
META-INF/versions/9/module-info.class
META-INF/versions/11/module-info.class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet, wdyt?
I couldn't think of anything better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@netodevel,@gsmet - sorry to bother, but I guess you have turned it the other way around:
instead of
if (!entry.getKey().endsWith("module-info.class"))
you have written:
if (!"module-info.class".endsWith(entry.getKey()))
which hardly ever would be the case, or?
Have found it still written the same way in the 2.6.1.Final
Fixes #20333 |
Sorry to bother, even though it has already been merged and may be I am missing something, but I guess there is a problem - #20370 (comment) |
Hmmm, you're right, I don't know how we missed it :/. Will fix. |
Issue: #20333
Removes log of module-info.class files duplicated between libs.
@Sanne,
How did you build the module:
quarkus-integration-test-main
?I'm trying to test the code above but I can't see these warning logs
how am i trying:
mvn verify -f integration-tests