Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax some warnings regarding duplicate resources during build #20333

Closed
Sanne opened this issue Sep 22, 2021 · 4 comments
Closed

Relax some warnings regarding duplicate resources during build #20333

Sanne opened this issue Sep 22, 2021 · 4 comments
Labels
area/core area/user-experience Will make us lose users good first issue Good for newcomers kind/enhancement New feature or request

Comments

@Sanne
Copy link
Member

Sanne commented Sep 22, 2021

Description

I'm seeing several warnings like the following when building the quarkus-integration-test-main module:

[WARNING] [io.quarkus.deployment.pkg.steps.JarResultBuildStep] Dependencies with duplicate files detected. The dependencies [com.fasterxml.jackson.module:jackson-module-jaxb-annotations::jar:2.12.5(runtime-cp deployment-cp compile), com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider::jar:2.12.5(runtime-cp deployment-cp compile), com.fasterxml.jackson.jaxrs:jackson-jaxrs-base::jar:2.12.5(runtime-cp deployment-cp compile)] contain duplicate files, e.g. META-INF/versions/11/module-info.class
[WARNING] [io.quarkus.deployment.pkg.steps.JarResultBuildStep] Dependencies with duplicate files detected. The dependencies [net.bytebuddy:byte-buddy::jar:1.11.16(runtime-cp deployment-cp compile), org.tukaani:xz::jar:1.9(runtime-cp deployment-cp compile), org.bouncycastle:bcutil-jdk15on::jar:1.69(runtime-cp deployment-cp compile), org.bouncycastle:bcprov-jdk15on::jar:1.69(runtime-cp deployment-cp compile), org.bouncycastle:bcpkix-jdk15on::jar:1.69(runtime-cp deployment-cp compile), org.bouncycastle:bcmail-jdk15on::jar:1.69(runtime-cp deployment-cp compile)] contain duplicate files, e.g. META-INF/versions/9/module-info.class

Many libraries are containing a module-info.class now; I think we should be able to ignore it and shouldn't log a warning about these, so to reduce the noise and make sure that actually important warnings are more visible.

Implementation ideas

Just filter them out.

@Sanne Sanne added kind/enhancement New feature or request area/core area/user-experience Will make us lose users good first issue Good for newcomers labels Sep 22, 2021
@netodevel
Copy link
Contributor

@Sanne, i would like get this issue

To understand better, should I ignore this warning to libraries that have java modules, right?

@Sanne
Copy link
Member Author

Sanne commented Sep 23, 2021

thanks for volunteering @netodevel !

To understand better, should I ignore this warning to libraries that have java modules, right?

More precisely it should ignore warnings about resources named module-info.class; it should still log a warning if the library which has a java module has some other resource duplicated.

@netodevel
Copy link
Contributor

@Sanne, the fix already merge, what do you think close this issue?

@Sanne
Copy link
Member Author

Sanne commented Oct 20, 2021

@Sanne, the fix already merge, what do you think close this issue?

thanks for pointing that out :) We should have marked this fixed when the PR was merged, missed it.

@Sanne Sanne closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/user-experience Will make us lose users good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants