-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gdb debugging with GraalVM/Mandrel >=21.1 #20355
Conversation
As if 21.1 (oracle/graal@dee66ca) dwarf info contain absolute paths to the source-cache. As a result moving the sources breaks gdb. The move was performed to make sure the sources are next to the binary, in an effort to ease debugging on remote hosts by copying the binary and the sources in the same directory. As discussed in oracle/graal#3828 this is not expected to be the common case, so it's better to favour the local debugging experience by leaving the sources where they were placed by GraalVM/Mandrel.
Don't we want to keep this capability for |
No, it's not worth it. This was just a "nice to have" that turned out to do more harm than good. |
Understood |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building db5ad51
Failures⚙️ Native Tests - Data6 #- Failing: integration-tests/elasticsearch-rest-client integration-tests/elasticsearch-rest-high-level-client integration-tests/hibernate-search-orm-elasticsearch and 1 more
📦 integration-tests/elasticsearch-rest-client✖ 📦 integration-tests/elasticsearch-rest-high-level-client✖ 📦 integration-tests/hibernate-search-orm-elasticsearch✖ 📦 integration-tests/hibernate-search-orm-elasticsearch-aws✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building db5ad51
|
Sources are no longer being moved to the `target` directory see quarkusio/quarkus#20355
As of 21.1 (oracle/graal@dee66ca)
dwarf info contain absolute paths to the source-cache. As a result
moving the sources breaks gdb.
The move was performed to make sure the sources are next to the binary,
in an effort to ease debugging on remote hosts by copying the binary and
the sources in the same directory. As discussed in
oracle/graal#3828 this is not expected to be the
common case, so it's better to favour the local debugging experience by
leaving the sources where they were placed by GraalVM/Mandrel.
Reverts: #12351
Closes: #20321