Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gdb debugging with GraalVM/Mandrel >=21.1 #20355

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 23, 2021

As of 21.1 (oracle/graal@dee66ca)
dwarf info contain absolute paths to the source-cache. As a result
moving the sources breaks gdb.

The move was performed to make sure the sources are next to the binary,
in an effort to ease debugging on remote hosts by copying the binary and
the sources in the same directory. As discussed in
oracle/graal#3828 this is not expected to be the
common case, so it's better to favour the local debugging experience by
leaving the sources where they were placed by GraalVM/Mandrel.

Reverts: #12351
Closes: #20321

As if
21.1 (oracle/graal@dee66ca)
dwarf info contain absolute paths to the source-cache. As a result
moving the sources breaks gdb.

The move was performed to make sure the sources are next to the binary,
in an effort to ease debugging on remote hosts by copying the binary and
the sources in the same directory.  As discussed in
oracle/graal#3828 this is not expected to be the
common case, so it's better to favour the local debugging experience by
leaving the sources where they were placed by GraalVM/Mandrel.
@geoand
Copy link
Contributor

geoand commented Sep 23, 2021

Don't we want to keep this capability for 20.3?

@zakkak
Copy link
Contributor Author

zakkak commented Sep 23, 2021

Don't we want to keep this capability for 20.3?

No, it's not worth it. This was just a "nice to have" that turned out to do more harm than good.

@geoand
Copy link
Contributor

geoand commented Sep 23, 2021

Understood

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Sep 23, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 23, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building db5ad51

Status Name Step Failures Logs Raw logs
Native Tests - Data6 Build Failures Logs Raw logs

Failures

⚙️ Native Tests - Data6 #

- Failing: integration-tests/elasticsearch-rest-client integration-tests/elasticsearch-rest-high-level-client integration-tests/hibernate-search-orm-elasticsearch and 1 more

📦 integration-tests/elasticsearch-rest-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start) on project quarkus-integration-test-elasticsearch-rest-client: I/O Error

📦 integration-tests/elasticsearch-rest-high-level-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start) on project quarkus-integration-test-elasticsearch-rest-high-level-client: I/O Error

📦 integration-tests/hibernate-search-orm-elasticsearch

Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start) on project quarkus-integration-test-hibernate-search-orm-elasticsearch: I/O Error

📦 integration-tests/hibernate-search-orm-elasticsearch-aws

Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start) on project quarkus-integration-test-hibernate-search-orm-elasticsearch-aws: I/O Error

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 23, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building db5ad51

Status Name Step Failures Logs Raw logs
Devtools Tests - JDK 11 Extract Maven Repo ⚠️ Check → Logs Raw logs
Devtools Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Extract Maven Repo ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Extract Maven Repo ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Extract Maven Repo ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Amazon Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Cache Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data1 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data2 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data3 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data4 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data5 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data6 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data7 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - DevTools Integration Tests Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - HTTP Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Main Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc1 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc2 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc3 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc4 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Security1 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Security2 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Security3 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Spring Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - gRPC Extract Maven Repo ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 23, 2021

Failing Jobs - Building db5ad51

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 16

@geoand geoand merged commit f0aba85 into quarkusio:main Sep 24, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 24, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 24, 2021
@zakkak zakkak deleted the fix-20321 branch September 24, 2021 06:40
@geoand geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 28, 2021
zakkak added a commit to zakkak/mandrel-integration-tests that referenced this pull request Oct 28, 2021
Sources are no longer being moved to the `target` directory see
quarkusio/quarkus#20355
@gsmet gsmet modified the milestones: 2.3.0.Final, 2.2.4.Final Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants