-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI yaml fixed after PR 60 changes, Whitelist regexp fix #61
Conversation
Seems this is no longer valid? Looking at my old comment.... |
Fixed in #62
No, that seems OK |
3c45a43
to
21d3942
Compare
@zakkak So, there is still a difference we need to account for, probably by patching before test the same way as compatibility with Quarkus 1.7 was done. Quarkus 2.2.3.Final + debug symbols + container is just fine. Quarkus 2.4.0.Final in that scenario is missing a file I am trying to copy in that Dockerfile:
/me running locally to nail it down, but apparently adding Quarkus 2.4.0.Final requires some migration work on TS. |
Q 2.4.0.Final
Q 2.2.3.Final
|
@Karm FYI quarkusio/quarkus#20355 is marked for backport to Quarkus 2.2 so eventually it will be the same for both. I guess our tests still need to cover this case till then though... |
@@ -22,12 +23,18 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
quarkus-version: ['2.2.3.Final', '2.4.0.Final'] | |||
mandrel-version: ['21.2.0.2-Final', '21.3.0.0-Final'] | |||
quarkus-version: ['1.11.7.Final', '2.2.3.Final', '2.4.0.Final'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still interested in Quarkus 1.11 and Mandrel 20.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakkak Not for testing Q or M. This is for knowing that TS is still compatible with it. It is too soon to go and purge all if (QUARKUS_VERSION.startsWith("1.")) {...
and thus remove the compatibility.
FAIL_ON_PERF_REGRESSION: false
@zakkak Seems fine now. Ad perf results: I will examine them on a baremetal lab box. |
No description provided.