-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraalVM 21.3 compatibility support for resource registration #20232
Conversation
Marking as Draft till we confirm that the change is going to land in the upcoming 21.3 CI run with 21.3-dev: https://github.com/graalvm/mandrel/actions/runs/1245375127 |
oops sorry @zakkak I didn't mean to promote it from "draft" status. Do you know how to undo that? |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building b441cbc
Failures⚙️ Initial JDK 11 Build #- Failing: core/deployment
! Skipped: core/test-extension/deployment core/test-extension/runtime devtools/bom-descriptor-json and 606 more 📦 core/deployment✖ |
oracle/graal#3774 changed the signature of ignoreResources as follows: ``` - public void ignoreResources(String pattern) { + public void ignoreResources(ConfigurationCondition condition, String pattern) { ``` This results in Quarkus throwing a `NoSuchMethodError` exception at the code generated by NativeImageAutoFeatureStep This patch looks for the right method based on the GraalVM/Mandrel version. Closes: quarkusio#20226
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building b5361d8
Full information is available in the Build summary check run. Failures⚙️ MicroProfile TCKs Tests #- Failing: tcks/microprofile-fault-tolerance
📦 tcks/microprofile-fault-tolerance✖
|
The test failures seem unrelated to this PR, please let me know if you see something wrong with it that I am missing. |
Marking for backport to make sure Q 2.2.x is compatible with the upcoming GraalVM/Mandrel 21.3 |
✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself. |
oracle/graal#3774 changed the signature of ignoreResources as follows:
This results in Quarkus throwing aNoSuchMethodError
exception at thecode generated by NativeImageAutoFeatureStep
and deprecated the old API (see oracle/graal#3803)
This patch looks for the right method based on the GraalVM/Mandrel version.
Closes: #20226