Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraalVM 21.3 compatibility support for resource registration #20232

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 17, 2021

oracle/graal#3774 changed the signature of ignoreResources as follows:

- public void ignoreResources(String pattern) {
+ public void ignoreResources(ConfigurationCondition condition, String pattern) {

This results in Quarkus throwing a NoSuchMethodError exception at the
code generated by NativeImageAutoFeatureStep

and deprecated the old API (see oracle/graal#3803)

This patch looks for the right method based on the GraalVM/Mandrel version.

Closes: #20226

@zakkak
Copy link
Contributor Author

zakkak commented Sep 17, 2021

Marking as Draft till we confirm that the change is going to land in the upcoming 21.3

CI run with 21.3-dev: https://github.com/graalvm/mandrel/actions/runs/1245375127

@Sanne Sanne marked this pull request as ready for review September 20, 2021 14:28
@Sanne
Copy link
Member

Sanne commented Sep 20, 2021

oops sorry @zakkak I didn't mean to promote it from "draft" status. Do you know how to undo that?

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b441cbc

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: core/deployment 
! Skipped: core/test-extension/deployment core/test-extension/runtime devtools/bom-descriptor-json and 606 more

📦 core/deployment

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.16.0:validate (default) on project quarkus-core-deployment: File '/home/runner/work/quarkus/quarkus/core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageAutoFeatureStep.java' has not been previously formatted. Please format file and commit before running validation!

@zakkak zakkak marked this pull request as draft September 20, 2021 15:28
oracle/graal#3774 changed the signature of ignoreResources as follows:

```
- public void ignoreResources(String pattern) {
+ public void ignoreResources(ConfigurationCondition condition, String pattern) {
```

This results in Quarkus throwing a `NoSuchMethodError` exception at the
code generated by NativeImageAutoFeatureStep

This patch looks for the right method based on the GraalVM/Mandrel version.

Closes: quarkusio#20226
@zakkak zakkak marked this pull request as ready for review September 21, 2021 12:22
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 21, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b5361d8

Status Name Step Failures Logs Raw logs
MicroProfile TCKs Tests Verify Failures Logs Raw logs
Native Tests - Data4 Download Maven Repo ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-fault-tolerance 

📦 tcks/microprofile-fault-tolerance

org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)

@zakkak
Copy link
Contributor Author

zakkak commented Sep 21, 2021

The test failures seem unrelated to this PR, please let me know if you see something wrong with it that I am missing.

@zakkak
Copy link
Contributor Author

zakkak commented Sep 21, 2021

Marking for backport to make sure Q 2.2.x is compatible with the upcoming GraalVM/Mandrel 21.3

@zakkak zakkak requested a review from geoand September 24, 2021 08:43
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 24, 2021

✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself.

@geoand geoand merged commit 30f34f6 into quarkusio:main Sep 24, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 24, 2021
@zakkak zakkak deleted the fix-20226 branch September 24, 2021 13:57
@geoand geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 28, 2021
@gsmet gsmet modified the milestones: 2.3.0.Final, 2.2.4.Final Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants