Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature of com.oracle.svm.core.configure.ResourcesRegistry.ignoreResources changed in GraalVM/Mandrel 21.3-dev #20226

Closed
zakkak opened this issue Sep 17, 2021 · 2 comments · Fixed by #20232
Closed

Signature of com.oracle.svm.core.configure.ResourcesRegistry.ignoreResources changed in GraalVM/Mandrel 21.3-dev #20226

zakkak opened this issue Sep 17, 2021 · 2 comments · Fixed by #20232
Assignees
@zakkak
Labels
area/mandrel area/native-image
Milestone
2.2.4.Final

Comments

@zakkak
Copy link
Contributor

zakkak commented Sep 17, 2021

oracle/graal#3774 changed the signature of ignoreResources as follows:

-                public void ignoreResources(String pattern) {
+                public void ignoreResources(ConfigurationCondition condition, String pattern) {

This results in Quarkus throwing a NoSuchMethodError exception at the code generated by:

quarkus/core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageAutoFeatureStep.java

Lines 78 to 80 in 9b1424d

private static final MethodDescriptor RESOURCES_REGISTRY_IGNORE_RESOURCES = ofMethod(
"com.oracle.svm.core.configure.ResourcesRegistry",
"ignoreResources", void.class, String.class);

@zakkak zakkak self-assigned this Sep 17, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 17, 2021

/cc @galderz

@zakkak
Copy link
Contributor Author

zakkak commented Sep 17, 2021

FTR oracle/graal#3803 will bring back the methods as deprecated default implementaions.

zakkak added a commit to zakkak/quarkus that referenced this issue Sep 17, 2021
@zakkak
Add GraalVM 21.3 compatibility support for resource registration
b441cbc 
oracle/graal#3774 changed the signature of ignoreResources as follows:

```
- public void ignoreResources(String pattern) {
+ public void ignoreResources(ConfigurationCondition condition, String pattern) {
```

This results in Quarkus throwing a `NoSuchMethodError` exception at the
code generated by NativeImageAutoFeatureStep

This patch looks for the right method based on the GraalVM/Mandrel version.

Closes: quarkusio#20226
@zakkak zakkak mentioned this issue Sep 17, 2021
Merged
zakkak added a commit to zakkak/quarkus that referenced this issue Sep 21, 2021
@zakkak
Add GraalVM 21.3 compatibility support for resource registration
20d0e69 
oracle/graal#3774 changed the signature of ignoreResources as follows:

```
- public void ignoreResources(String pattern) {
+ public void ignoreResources(ConfigurationCondition condition, String pattern) {
```

This results in Quarkus throwing a `NoSuchMethodError` exception at the
code generated by NativeImageAutoFeatureStep

This patch looks for the right method based on the GraalVM/Mandrel version.

Closes: quarkusio#20226
zakkak added a commit to zakkak/quarkus that referenced this issue Sep 21, 2021
@zakkak
Add GraalVM 21.3 compatibility support for resource registration
b5361d8 
oracle/graal#3774 changed the signature of ignoreResources as follows:

```
- public void ignoreResources(String pattern) {
+ public void ignoreResources(ConfigurationCondition condition, String pattern) {
```

This results in Quarkus throwing a `NoSuchMethodError` exception at the
code generated by NativeImageAutoFeatureStep

This patch looks for the right method based on the GraalVM/Mandrel version.

Closes: quarkusio#20226
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 24, 2021
@geoand geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 28, 2021
geoand pushed a commit to geoand/quarkus that referenced this issue Sep 28, 2021
@zakkak @geoand
Add GraalVM 21.3 compatibility support for resource registration
20f34ad 
oracle/graal#3774 changed the signature of ignoreResources as follows:

```
- public void ignoreResources(String pattern) {
+ public void ignoreResources(ConfigurationCondition condition, String pattern) {
```

This results in Quarkus throwing a `NoSuchMethodError` exception at the
code generated by NativeImageAutoFeatureStep

This patch looks for the right method based on the GraalVM/Mandrel version.

Closes: quarkusio#20226
(cherry picked from commit b5361d8)
@gsmet gsmet modified the milestones: 2.3.0.Final, 2.2.4.Final Nov 30, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Dec 1, 2021
@zakkak @gsmet
Add GraalVM 21.3 compatibility support for resource registration
3a99ba1 
oracle/graal#3774 changed the signature of ignoreResources as follows:

```
- public void ignoreResources(String pattern) {
+ public void ignoreResources(ConfigurationCondition condition, String pattern) {
```

This results in Quarkus throwing a `NoSuchMethodError` exception at the
code generated by NativeImageAutoFeatureStep

This patch looks for the right method based on the GraalVM/Mandrel version.

Closes: quarkusio#20226
(cherry picked from commit b5361d8)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Dec 1, 2021
@zakkak @gsmet
Add GraalVM 21.3 compatibility support for resource registration
a4ba4c8 
oracle/graal#3774 changed the signature of ignoreResources as follows:

```
- public void ignoreResources(String pattern) {
+ public void ignoreResources(ConfigurationCondition condition, String pattern) {
```

This results in Quarkus throwing a `NoSuchMethodError` exception at the
code generated by NativeImageAutoFeatureStep

This patch looks for the right method based on the GraalVM/Mandrel version.

Closes: quarkusio#20226
(cherry picked from commit b5361d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zakkak zakkak

Labels
area/mandrel area/native-image
Projects
None yet
Milestone
2.2.4.Final
Development

Successfully merging a pull request may close this issue.

Add GraalVM 21.3 compatibility support for resource registration zakkak/quarkus
3 participants
@gsmet @zakkak @geoand