Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability for extensions to exclude GraalVM config from jars [Revisited] #19806

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Aug 31, 2021

Resolves: #17482

It seems that by listing the arguments in this particular order, we can workaround the GraalVM issue. Thanks @galderz !

@Sanne Sanne requested a review from geoand August 31, 2021 16:40
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see we have a workaround!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 31, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 31, 2021

Failing Jobs - Building 58e48e0

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 16

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: devtools/gradle 

📦 devtools/gradle

Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (gradle) on project io.quarkus.gradle.plugin: Command execution failed.

@Sanne Sanne merged commit 236dc6b into quarkusio:main Aug 31, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 31, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 31, 2021
@Sanne Sanne deleted the GraalExclusions2Cleanup branch August 31, 2021 20:45
@galderz
Copy link
Member

galderz commented Sep 1, 2021

FYI the upstream GraalVM issue is oracle/graal#3742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass --exclude-config programatically
5 participants