-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass --exclude-config programatically #17482
Comments
@galderz do you plan on making this available for easy use in Quarkus? |
@geoand No, that's not something I'm looking into. |
Thanks for the info @galderz. I assume that at some point this is something we would want to have in Quarkus |
@Sanne this is something you wanted as well, right? |
Right! We have an immediate need in the case of the Oracle JDBC driver, and I totally expect more libraries in the future to occasionally include some mistakes, which we would only be able to work around when we have this. |
@galderz how would one access this programmatically from a Feature? |
@geoand I don't think doing this a Feature is possible. The code that excludes jars/resources works in the 1st stage of native-image, the driver phase. This phase constructs a java invocation for the second phase and hence we exclude things to being passed on to the 2nd phase, where Feature instances and others come into play. I would expect that each extension would define 0..N |
Gotcha. I'll look into it hopefully sometime soon |
Features should be able to change the flags which we feed into the |
Ah, you mean Quarkus Features? I thought @geoand was referring to GraalVM Features... :) |
Yes, I did mean GraalVM Features |
ah ok. Yes it definitely needs to be at the level of command line arguments, anything else would be too late. |
Add the ability for extensions to exclude GraalVM config from jars
Resolves: quarkusio#17482 (cherry picked from commit f36724b)
Resolves: quarkusio#17482 (cherry picked from commit f36724b)
--exclude-config
was introduced in oracle/graal#3179It would be nice to be able to pass it programatically from a Quarkus extension
The text was updated successfully, but these errors were encountered: