Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codestarts - gRPC - add index.html #19796

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Codestarts - gRPC - add index.html #19796

merged 1 commit into from
Sep 2, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 31, 2021

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Aug 31, 2021
@michalszynkiewicz
Copy link
Member

Looks good from my PoV. But I know nothing about codestarts. I'll ask Andy for review too

ia3andy
ia3andy approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ia3andy ia3andy merged commit f9c9a0d into quarkusio:main Sep 2, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 2, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.2.Final Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@michalszynkiewicz michalszynkiewicz Awaiting requested review from michalszynkiewicz

Assignees
No one assigned
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
2.2.2.Final
Development

Successfully merging this pull request may close these issues.

add tip in grpc code start to tell user how it works
4 participants
@mkouba @michalszynkiewicz @ia3andy @gsmet