Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tip in grpc code start to tell user how it works #19642

Closed
maxandersen opened this issue Aug 25, 2021 · 3 comments · Fixed by #19796
Closed

add tip in grpc code start to tell user how it works #19642

maxandersen opened this issue Aug 25, 2021 · 3 comments · Fixed by #19796
Assignees
Labels
area/grpc gRPC kind/enhancement New feature or request
Milestone

Comments

@maxandersen
Copy link
Member

Description

I tried the grpc code start out just using the cli with quarkus create -x io.quarkus:quarkus-grpc mygrpc and run quarkus dev and it works.

there is no index.html so localhost:8080 gives no info and in the readme.md it just points to https://quarkus.io/guides/grpc-getting-started which
explains how to write this. No indication to user what he can/should do.

Maybe keep index.html ? and add to it and readme.md a mention like:

"This grpc codestart gives you a basic grpc endpoint you can test in the dev ui at /q/dev/io.quarkus.quarkus-grpc/services. The guide at https://quarkus.io/guides/grpc-getting-started explains the code involved.

Implementation ideas

No response

@maxandersen maxandersen added the kind/enhancement New feature or request label Aug 25, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 25, 2021

/cc @cescoffier, @michalszynkiewicz

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Aug 25, 2021
@michalszynkiewicz
Copy link
Member

cc @mkouba

@mkouba mkouba self-assigned this Aug 27, 2021
mkouba added a commit to mkouba/quarkus that referenced this issue Aug 31, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 2, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.2.Final Sep 6, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Sep 6, 2021
- resolves quarkusio#19642

(cherry picked from commit 57d2f7c)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Sep 6, 2021
- resolves quarkusio#19642

(cherry picked from commit 57d2f7c)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Sep 6, 2021
- resolves quarkusio#19642

(cherry picked from commit 57d2f7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants