Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ANTLR from 4.8 to 4.9.2 #19551

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Bump ANTLR from 4.8 to 4.9.2 #19551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
<quarkus-spring-boot-api.version>2.1.SP1</quarkus-spring-boot-api.version>
<mockito.version>3.11.2</mockito.version>
<jna.version>5.3.1</jna.version><!-- should satisfy both testcontainers and mongodb -->
<antlr.version>4.8</antlr.version>
<antlr.version>4.9.2</antlr.version>
<quarkus-security.version>1.1.4.Final</quarkus-security.version>
<keycloak.version>14.0.0</keycloak.version>
<logstash-gelf.version>1.14.1</logstash-gelf.version>
Expand Down
2 changes: 1 addition & 1 deletion build-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
<microprofile-graphql-api.version>1.1.0</microprofile-graphql-api.version>

<!-- Antlr is used by the PanacheQL parser-->
<antlr.version>4.8</antlr.version>
<antlr.version>4.9.2</antlr.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a duplicate? If it's in the BOM, it could probably be removed from the build-parent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used for antlr4-maven-plugin, so the BOM is not of help here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be moved to the root parent then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version property? So that there is only one property, also for the BOM? Or just for the plugin?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to have it in one place. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this should work, but then again it would be a paradigm shift because currently, all BOM-relevant properties are set only in the BOM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can discuss changing how we do things but that's for another day. For now, properties are either in the BOM or in the build-parent.

Maybe having all of them in the parent would indeed be an improvement but let's discuss this separately.


<!-- Defaults for integration tests -->
<elasticsearch-server.version>7.10.0</elasticsearch-server.version>
Expand Down