Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ANTLR from 4.8 to 4.9.2 #19551

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Bump ANTLR from 4.8 to 4.9.2 #19551

merged 1 commit into from
Aug 23, 2021

Conversation

famod
Copy link
Member

@famod famod commented Aug 20, 2021

This removes warnings like:

ANTLR Runtime version 4.9.2 used for parser compilation does not match the current runtime version 4.8

AFAICS, the only one complaining now (in the reverse way) is GraphQL:

[INFO] Running io.quarkus.vertx.graphql.it.VertxGraphqlTest
ANTLR Tool version 4.8 used for code generation does not match the current runtime version 4.9.2
2021-08-20 15:17:57,694 INFO  [io.quarkus] (main) Quarkus 999-SNAPSHOT on JVM started in 4.257s. Listening on: http://localhost:8081
ANTLR Runtime version 4.8 used for parser compilation does not match the current runtime version 4.9.2
2021-08-20 15:17:57,696 INFO  [io.quarkus] (main) Profile test activated. 
ANTLR Tool version 4.8 used for code generation does not match the current runtime version 4.9.2
2021-08-20 15:17:57,696 INFO  [io.quarkus] (main) Installed features: [cdi, smallrye-context-propagation, vertx-graphql]
ANTLR Runtime version 4.8 used for parser compilation does not match the current runtime version 4.9.2
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.792 s - in io.quarkus.vertx.graphql.it.VertxGraphqlTest
2021-08-20 15:18:00,403 INFO  [io.quarkus] (main) Quarkus stopped in 0.022s

But seeing how little was changed in GraphQL 17.0 to use ANTLR 4.9.2, I'd say it should be ok: graphql-java/graphql-java#2323

Ideally, GraphQL should be updated in vertx-web-graphql and then updated in Quarkus.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Aug 20, 2021
@famod
Copy link
Member Author

famod commented Aug 20, 2021

/cc @phillip-kruger @jmartisk not sure that GraphQL update is something for you because I saw graphql-java coming from vertx-web-graphql, not smallrye. 🤷

@@ -75,7 +75,7 @@
<microprofile-graphql-api.version>1.1.0</microprofile-graphql-api.version>

<!-- Antlr is used by the PanacheQL parser-->
<antlr.version>4.8</antlr.version>
<antlr.version>4.9.2</antlr.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a duplicate? If it's in the BOM, it could probably be removed from the build-parent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used for antlr4-maven-plugin, so the BOM is not of help here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be moved to the root parent then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version property? So that there is only one property, also for the BOM? Or just for the plugin?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to have it in one place. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this should work, but then again it would be a paradigm shift because currently, all BOM-relevant properties are set only in the BOM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can discuss changing how we do things but that's for another day. For now, properties are either in the BOM or in the build-parent.

Maybe having all of them in the parent would indeed be an improvement but let's discuss this separately.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 20, 2021

Failing Jobs - Building 54c14a2

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CustomQuarkusDevModeConfigurationTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:908)
	at io.quarkus.test.devmode.util.DevModeTestUtils.getHttpResponse(DevModeTestUtils.java:130)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:126)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpRes...

@gsmet gsmet merged commit 7eb76b4 into quarkusio:main Aug 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 23, 2021
@famod famod deleted the antlr-4.9.2 branch August 24, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants