Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not filter binary resources and SVG #19260

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 5, 2021

Fixes the issue we had with Dev UI favicon.ico
Fixes #19117

Fixes the issue we had with Dev UI favicon.ico
Fixes quarkusio#19117
@gsmet gsmet requested a review from rsvoboda August 5, 2021 14:17
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Aug 5, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 87d2c9c

Status Name Step Test failures Logs Raw logs
Devtools Tests - JDK 11 Download Maven Repo ⚠️ Check → Logs Raw logs
Devtools Tests - JDK 11 Windows Download Maven Repo ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Download Maven Repo ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Download Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Download Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Download Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Download Maven Repo ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Download Maven Repo ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Windows Download Maven Repo ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Amazon ⚠️ Check → Logs Raw logs
Native Tests - Cache Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data1 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data2 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data3 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data4 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data5 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data6 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data7 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - DevTools Integration Tests Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - HTTP Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Main Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc1 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc2 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc3 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc4 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Security1 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Security2 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Security3 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Spring Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - gRPC Download Maven Repo ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 87d2c9c

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.metrics.MicrometerTimedTest.testTimedMethod line 51 - More details - Source on GitHub

io.micrometer.core.instrument.search.MeterNotFoundException: 
Unable to find a meter that matches all the requirements at once. Here's what was found:
   FAIL: No meter with name 'scheduled.methods' was found.
   OK: A meter with type timer was found.
   FAIL: No meters have the required tag 'method'.
   FAIL: No meters have the required tag 'class'.
   OK: A meter with name 'scheduled.methods' has a tag 'exception' with value 'none'.
	at io.micrometer.core.instrument.search.MeterNotFoundException$FromRequiredSearch.build(MeterNotFoundException.java:228)
	at io.micrometer.core.instrument.search.MeterNotFoundException$FromRequiredSearch.access$100(MeterNotFoundException.java:46)
	at io.micrometer.core.instrument.search.MeterNotFoundException.forSearch(MeterNotFoundException.java:43)
	at io.micrometer.core.instrument.search.RequiredSearch.findOne(RequiredSearch.java:199)
	at io.micrometer.core.instrument.search.RequiredSearch.timer(RequiredSearch.java:122)
	at io.quarkus.scheduler.tes...

⚙️ JVM Tests - JDK 16 #

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.metrics.MicrometerTimedTest.testTimedMethod line 51 - More details - Source on GitHub

io.micrometer.core.instrument.search.MeterNotFoundException: 
Unable to find a meter that matches all the requirements at once. Here's what was found:
   OK: A meter with name 'scheduled.methods' was found.
   OK: Meters with type timer were found.
   OK: A meter with name 'scheduled.methods' has a tag 'method' with value 'everySecond'.
   OK: A meter with name 'scheduled.methods' has a tag 'class' with value 'io.quarkus.scheduler.test.metrics.MicrometerTimedTest$Jobs'.
   OK: A meter with name 'scheduled.methods' has a tag 'exception' with value 'none'.
	at io.micrometer.core.instrument.search.MeterNotFoundException$FromRequiredSearch.build(MeterNotFoundException.java:228)
	at io.micrometer.core.instrument.search.MeterNotFoundException$FromRequiredSearch.access$100(MeterNotFoundException.java:46)
	at io.micrometer.core.instrument.search.MeterNotFoundException.forSearch(MeterNotFoundException.java:43)
	at io.micrometer.core.instrument.search.RequiredSearch.findOne(RequiredSearch.jav...

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

favicon is visible now, thanks for the PR

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 6, 2021

Failing Jobs - Building 87d2c9c

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
Native Tests - Data3 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/oidc-wiremock

io.quarkus.it.keycloak.BearerOpaqueTokenAuthorizationTest.testSecureAccessSuccessPreferredUsername line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCa...

io.quarkus.it.keycloak.BearerOpaqueTokenAuthorizationTest.testDeniedAccessAdminResource line 47 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <403> but was <500>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:277)
	at io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure.valid...

io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testBearerTokenWrongIssuer line 86 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <401> but was <500>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:277)
	at io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure.valid...

io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testBearerTokenWrongAudience line 97 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <401> but was <500>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:277)
	at io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure.valid...

⚙️ JVM Tests - JDK 16 #

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.metrics.MicrometerTimedTest.testTimedMethod line 51 - More details - Source on GitHub

io.micrometer.core.instrument.search.MeterNotFoundException: 
Unable to find a meter that matches all the requirements at once. Here's what was found:
   FAIL: No meter with name 'scheduled.methods' was found.
   OK: Meters with type timer were found.
   OK: A meter with name 'scheduled.methods' has a tag 'method' with value 'everySecond'.
   OK: A meter with name 'scheduled.methods' has a tag 'class' with value 'io.quarkus.scheduler.test.metrics.MicrometerTimedTest$Jobs'.
   OK: A meter with name 'scheduled.methods' has a tag 'exception' with value 'none'.
	at io.micrometer.core.instrument.search.MeterNotFoundException$FromRequiredSearch.build(MeterNotFoundException.java:228)
	at io.micrometer.core.instrument.search.MeterNotFoundException$FromRequiredSearch.access$100(MeterNotFoundException.java:46)
	at io.micrometer.core.instrument.search.MeterNotFoundException.forSearch(MeterNotFoundException.java:43)
	at io.micrometer.core.instrument.search.RequiredSearch.findOne(RequiredSearch....

@gsmet gsmet merged commit 2db6421 into quarkusio:main Aug 6, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 6, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.2.Final Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken favicon for Dev UI
2 participants