Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken favicon for Dev UI #19117

Closed
rsvoboda opened this issue Jul 30, 2021 · 1 comment · Fixed by #19260
Closed

Broken favicon for Dev UI #19117

rsvoboda opened this issue Jul 30, 2021 · 1 comment · Fixed by #19260
Assignees
@gsmet
Labels
area/dev-ui kind/bug Something isn't working
Milestone
2.1.2.Final

Comments

@rsvoboda
Copy link
Member

Describe the bug

Broken favicon for Dev UI, nice one is when using Quarkus 1.13.7.Final.

Quarkus 2.0.0.Final and 2.1.0.Final bring weird gray something instead of favicon similar to the usual one like in case of https://quarkus.io/

http://localhost:8080/q/dev/resources/images/favicon.ico (you may need to hit Ctrl+R to force reload or open the link in private mode)
Screenshot 2021-07-30 at 8 48 23

Expected behavior

favicon similar to the one used on https://quarkus.io/ page

Actual behavior

Current favicon - weird gray something

How to Reproduce?

Output of uname -a or ver

No response

Output of java -version

Java 11

GraalVM version (if different from Java)

No response

Quarkus version or git rev

Quarkus 2.1.0.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@rsvoboda rsvoboda added the kind/bug Something isn't working label Jul 30, 2021
@famod
Copy link
Member

famod commented Jul 30, 2021

I've also seen exceptions being logged about this.

@gsmet gsmet self-assigned this Aug 5, 2021
gsmet added a commit to gsmet/quarkus that referenced this issue Aug 5, 2021
@gsmet
Do not filter binary resources and SVG
87d2c9c 
Fixes the issue we had with Dev UI favicon.ico
Fixes quarkusio#19117
@gsmet gsmet mentioned this issue Aug 5, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 6, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.2.Final Aug 9, 2021
gsmet added a commit to gsmet/quarkus that referenced this issue Aug 9, 2021
@gsmet
Do not filter binary resources and SVG
224b30b 
Fixes the issue we had with Dev UI favicon.ico
Fixes quarkusio#19117

(cherry picked from commit 87d2c9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsmet gsmet

Labels
area/dev-ui kind/bug Something isn't working
Projects
None yet
Milestone
2.1.2.Final
Development

Successfully merging a pull request may close this issue.

Do not filter binary resources and SVG gsmet/quarkus
3 participants
@rsvoboda @gsmet @famod