Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Dev Services not always working #19211

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extensions/reactive-mssql-client/deployment/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-smallrye-health-spi</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-devservices-mssql</artifactId>
</dependency>

<dependency>
<groupId>io.quarkus</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.quarkus.datasource.common.runtime.DataSourceUtil;
import io.quarkus.datasource.common.runtime.DatabaseKind;
import io.quarkus.datasource.deployment.spi.DefaultDataSourceDbKindBuildItem;
import io.quarkus.datasource.deployment.spi.DevServicesDatasourceConfigurationHandlerBuildItem;
import io.quarkus.datasource.runtime.DataSourceBuildTimeConfig;
import io.quarkus.datasource.runtime.DataSourcesBuildTimeConfig;
import io.quarkus.datasource.runtime.DataSourcesRuntimeConfig;
Expand Down Expand Up @@ -73,6 +74,16 @@ ServiceStartBuildItem build(BuildProducer<FeatureBuildItem> feature,
return new ServiceStartBuildItem("reactive-mssql-client");
}

@BuildStep
DevServicesDatasourceConfigurationHandlerBuildItem devDbHandler() {
return DevServicesDatasourceConfigurationHandlerBuildItem.reactive(DatabaseKind.MSSQL);
}

@BuildStep
DefaultDataSourceDbKindBuildItem dbType() {
return new DefaultDataSourceDbKindBuildItem(DatabaseKind.MSSQL);
}

/**
* The health check needs to be produced in a separate method to avoid a circular dependency (the Vert.x instance creation
* consumes the AdditionalBeanBuildItems).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ DevServicesDatasourceConfigurationHandlerBuildItem devDbHandler() {
return DevServicesDatasourceConfigurationHandlerBuildItem.reactive(DatabaseKind.MYSQL);
}

@BuildStep
DefaultDataSourceDbKindBuildItem dbType() {
return new DefaultDataSourceDbKindBuildItem(DatabaseKind.MYSQL);
}

/**
* The health check needs to be produced in a separate method to avoid a circular dependency (the Vert.x instance creation
* consumes the AdditionalBeanBuildItems).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public class MySQLPoolProducerTest {

@RegisterExtension
static final QuarkusUnitTest config = new QuarkusUnitTest()
.withConfigurationResource("application-default-datasource.properties")
.setArchiveProducer(() -> ShrinkWrap.create(JavaArchive.class)
.addClasses(BeanUsingBareMySQLClient.class)
.addClasses(BeanUsingMutinyMySQLClient.class));
Expand Down

This file was deleted.