Reactive Dev Services not always working #19211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This was not implemented for MSSQL - MYSQL required the db kind to be specified Fixes quarkusio#19208
gsmet
approved these changes
Aug 3, 2021
|
Hi @stuartwdouglas, looks like we had the same idea 😄 I already submitted a PR with roughly the same changes, see #19210. Can we combine the work? |
|
Oops, looks like we were working on it at the same time. We don't really want to test DB2/MSSQL because of licensing issues (you need to accept the license to run them, and we don't really want to be implicitly accepting it as part of the build IMHO). Can you just make the same test change in your PR? MySql is tested, but because the db-kind is in the file the missing driver build item was not picked up. |
quarkus-bot
bot
added
triage/invalid
|
np 👍 added the changes to the tests to my pr too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19208