Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add the consumer group id if the Kafka config is not empty #18832

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Only add the consumer group id if the Kafka config is not empty #18832

merged 1 commit into from
Jul 20, 2021

Conversation

cescoffier
Copy link
Member

Fix #18811

@cescoffier cescoffier requested review from Ladicek and geoand July 19, 2021 17:02
@gsmet
Copy link
Member

gsmet commented Jul 19, 2021

Is it something we need to backport to 2.1?

@cescoffier
Copy link
Member Author

@gsmet yes, it's harmless.

@geoand geoand merged commit bde19ba into quarkusio:main Jul 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 20, 2021
@cescoffier cescoffier deleted the do-not-add-group-id-to-kafka-config-if-empty branch July 20, 2021 06:57
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.0.Final Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@Ladicek Ladicek Awaiting requested review from Ladicek

Assignees
No one assigned
Labels
area/kafka
Projects
None yet
Milestone
2.1.0.Final
Development

Successfully merging this pull request may close these issues.

Avoid configuring kafka.group.id if no other Kafka configuration is present
3 participants
@cescoffier @gsmet @geoand