Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid configuring kafka.group.id if no other Kafka configuration is present #18811

Closed
jamesnetherton opened this issue Jul 19, 2021 · 2 comments · Fixed by #18832
Closed

Avoid configuring kafka.group.id if no other Kafka configuration is present #18811

jamesnetherton opened this issue Jul 19, 2021 · 2 comments · Fixed by #18832
Labels
area/kafka kind/enhancement New feature or request
Milestone
2.1.0.Final

Comments

@jamesnetherton
Copy link
Contributor

Description

Something that was observed in a Camel Quarkus issue is that KafkaRuntimeConfigProducer will potentially always add config for kafka.group.id, regardless of whether any other Kafka configuration has been specified. It seems redundant in this case, so it'd be nice if it could be avoided.

Implementation ideas

If the result map is empty - don't add kafka.group.id.
@jamesnetherton jamesnetherton added the kind/enhancement New feature or request label Jul 19, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2021

/cc @cescoffier

@cescoffier
Copy link
Member

Make sense. The fix is trivial.

cescoffier added a commit to cescoffier/quarkus that referenced this issue Jul 19, 2021
@cescoffier
Fix quarkusio#18811 - Only add the consumer group id if the Kafka con…
eef7581 
…fig is not empty
@cescoffier cescoffier mentioned this issue Jul 19, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 20, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.0.Final Jul 21, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jul 21, 2021
@cescoffier @gsmet
Fix quarkusio#18811 - Only add the consumer group id if the Kafka con…
17b8ce6 
…fig is not empty

(cherry picked from commit eef7581)
@jponge jponge mentioned this issue Jul 27, 2021
Closed
@jponge jponge mentioned this issue Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kafka kind/enhancement New feature or request
Projects
None yet
Milestone
2.1.0.Final
3 participants
@cescoffier @gsmet @jamesnetherton