Introduce UberJarMergedResourceBuildItem and UberJarIgnoredResourceBuildItem

[gastaldi]

Fixes #5677

[gsmet]

I haven't looked at it in detail but it would be better to name it UberJarMergedResourceBuildItem.

The way it is right now, it looks like an event that is triggered once resources are merged.

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 2729dc4

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	Build	⚠️ Check →	Logs	Raw logs

Changes addressed

[geoand]

It would be nice to have some kind of test for this

[gastaldi]

It would be nice to have some kind of test for this

Definitely! Can you point me to a test that uses Build Items for reference?

[geoand]

See

quarkus/extensions/mongodb-client/deployment/src/test/java/io/quarkus/mongodb/MongoNamedClientClientBuildItemConsumerTest.java

Line 34 in 2cbd177

.addBuildChainCustomizer(buildCustomizer());

for an example of customizing the build for a test

[gastaldi]

@geoand hm, that doesn't seem to work for building Uber JARs 😞 Should I use QuarkusProdModeTest with setRun(true) instead?

[gastaldi]

More specifically, this test doesn't work:

package io.quarkus.deployment.pkg.builditem;

import java.io.IOException;
import java.net.URL;
import java.util.Collections;
import java.util.Enumeration;
import java.util.function.Consumer;

import io.quarkus.bootstrap.model.AppArtifact;
import io.quarkus.builder.BuildChainBuilder;
import io.quarkus.test.QuarkusUnitTest;
import org.jboss.shrinkwrap.api.ShrinkWrap;
import org.jboss.shrinkwrap.api.spec.JavaArchive;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

import static org.assertj.core.api.Assertions.assertThat;

class UberJarMergedResourceBuildItemTest {

    @RegisterExtension
    static QuarkusUnitTest runner = new QuarkusUnitTest()
            .setArchiveProducer(() -> ShrinkWrap.create(JavaArchive.class))
            .withConfigurationResource("application-uber-jar.properties")
            .setForcedDependencies(
                    Collections.singletonList(
                            new AppArtifact("org.apache.cxf", "cxf-rt-transports-http", "3.4.3")
                    ))
            .addBuildChainCustomizer(buildCustomizer());

    @Test
    public void testResourceWasMerged() throws IOException {
        List<URL> resources = Collections.list(getClass().getClassLoader().getResources("META-INF/cxf/bus-extensions.txt"));
        assertThat(resources).hasSize(1);
    }

    static Consumer<BuildChainBuilder> buildCustomizer() {
        return (buildChainBuilder ->
                buildChainBuilder
                        .addBuildStep(context ->
                                              context.produce(new UberJarMergedResourceBuildItem("META-INF/cxf/bus-extensions.txt")))
                        .produces(UberJarMergedResourceBuildItem.class)
                        .build()
        );
    }
}

[geoand]

Ah darn, you are right.

We would likely need to add the same capability to the prod mode test.

[gastaldi]

Hm, QuarkusProdModeTest doesn't seem to work either. I'm adding my test to the core/test-extension/deployment because I can't add it to core/deployment (it would introduce a circular reference to quarkus-junit5-internal) but then it breaks other build steps 😛
This is painful.

[gastaldi]

It would be nice to backport this feature so our Quarkiverse maintainers could use it in the 1.13.x versions

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 12f58ac

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	Build	⚠️ Check →	Logs	Raw logs

[gsmet]

There is an import issue.

Next 1.13 (and probably last) will be released on Wednesday morning.

[gsmet]

The imports need a fix and the tests could be improved a bit. If this is done before tomorrow evening, I can backport it. Thanks!

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building cc06b7b

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	Build	⚠️ Check →	Logs	Raw logs

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cc2d7a9

Status	Name	Step	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Linux	Build	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	Build	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	Build	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 16 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

---

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 16 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

---

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/resteasy-reactive-rest-client

✖ io.quarkus.it.rest.client.BasicTest.shouldWork line 30 - More details - Source on GitHub

Changes addressed