Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shade-like transformers for uberjar creation #5677

Closed
esteban-aliverti opened this issue Nov 22, 2019 · 1 comment · Fixed by #17077
Closed

shade-like transformers for uberjar creation #5677

esteban-aliverti opened this issue Nov 22, 2019 · 1 comment · Fixed by #17077
Assignees
Labels
area/build kind/enhancement New feature or request
Milestone

Comments

@esteban-aliverti
Copy link
Contributor

Description
When creating an uberjar with Quarkus, there is no way to deal with duplicated resources in the dependencies. The first resource found will be used and any other subsequent resource will be omitted.

This is a typical problem when working with spring or many other frameworks that have duplicate entries under /src/main/resources/META-INF in the different .jar files that compose the framework.

Implementation ideas
The idea would be to
a) Try to integrate with maven's shade plugin. This plugin already has a built-in mechanism to deal with duplicated resources.
b) If the integration with shade is not possible, it would be nice to at least support a similar mechanism to declare transformers for files in the quarkus-maven-plugin.

@esteban-aliverti esteban-aliverti added the kind/enhancement New feature or request label Nov 22, 2019
@ldgut
Copy link

ldgut commented Dec 16, 2019

Same problem here.
resources/META-INF files are overwritten from files in maven dependencies. This only occurs in the runner.jar uberJar from versions above quarkus 0.22.0. We are using maven-shade plugin 3.2.1 which worked fine in 0.22.0.

@gastaldi gastaldi self-assigned this May 7, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 7, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 7, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 7, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 7, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 7, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 10, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 10, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 10, 2021
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 10, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 11, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 1.13.4.Final May 12, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants