Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz - remove the deprecated StoreType.DB #16965

Merged
merged 1 commit into from
May 4, 2021
Merged

Quartz - remove the deprecated StoreType.DB #16965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/quartz/deployment/src/test/java/io/quarkus/quartz/test/MissingDataSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class MissingDataSourceTest {
.setExpectedException(ConfigurationError.class)
.setArchiveProducer(() -> ShrinkWrap.create(JavaArchive.class)
.addClasses(SimpleJobs.class)
.addAsResource(new StringAsset("quarkus.quartz.store-type=db"), "application.properties"));
.addAsResource(new StringAsset("quarkus.quartz.store-type=jdbc-cmt"), "application.properties"));

@Test
public void shouldFailAndNotReachHere() {
Expand Down
5 changes: 3 additions & 2 deletions extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzBuildTimeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ public class QuartzBuildTimeConfig {
/**
* The type of store to use.
* <p>
* When using the `db` store type configuration value make sure that you have the datasource configured.
* See <a href="https://quarkus.io/guides/datasource"> Configuring your datasource</a> for more information.
* When using {@link StoreType#JDBC_CMT} or {@link StoreType#JDBC_TX} configuration values make sure that you have the
* datasource configured. See <a href="https://quarkus.io/guides/datasource"> Configuring your datasource</a> for more
* information.
* <p>
* To create Quartz tables, you can perform a schema migration via the <a href="https://quarkus.io/guides/flyway"> Flyway
* extension</a> using a SQL script matching your database picked from <a href=
Expand Down
11 changes: 1 addition & 10 deletions extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/StoreType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,7 @@
public enum StoreType {
RAM("org.quartz.simpl.RAMJobStore", "RAMJobStore"),
JDBC_TX("org.quartz.impl.jdbcjobstore.JobStoreTX", "JobStoreTX"),
JDBC_CMT("org.quartz.impl.jdbcjobstore.JobStoreCMT", "JobStoreCMT"),

/**
* @deprecated This is retained for retained for compatibility reasons
* and will be removed post Quarkus 1.6. Use {@link StoreType#JDBC_CMT}
* or Use {@link StoreType#JDBC_TX} instead depending on the
* transaction behaviour you need.
*/
@Deprecated
DB("org.quartz.impl.jdbcjobstore.JobStoreCMT", "JobStoreCMT");
JDBC_CMT("org.quartz.impl.jdbcjobstore.JobStoreCMT", "JobStoreCMT");

public String clazz;
public String simpleName;
Expand Down