Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz - remove the deprecated StoreType.DB #16965

Merged
merged 1 commit into from
May 4, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 4, 2021

No description provided.

@mkouba mkouba requested a review from machi1990 May 4, 2021 06:42
@mkouba mkouba added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label May 4, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 4, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 02982b0

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/quartz/deployment

io.quarkus.quartz.test.MissingDataSourceTest. - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/quartz/deployment

io.quarkus.quartz.test.MissingDataSourceTest. - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 extensions/quartz/deployment

io.quarkus.quartz.test.MissingDataSourceTest. - More details - Source on GitHub

Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There are some CI failure because of usage of the removed enum. Can you have a look?

@mkouba mkouba force-pushed the quartz-remove-StoreTypeDB branch from 02982b0 to 66a0191 Compare May 4, 2021 07:28
@mkouba
Copy link
Contributor Author

mkouba commented May 4, 2021

@machi1990 Should be fixed now.

@mkouba mkouba merged commit ba39f5d into quarkusio:main May 4, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 4, 2021
@Sgitario
Copy link
Contributor

Sgitario commented May 4, 2021

I think this change should be mentioned in the migration guide (to use jdbc-cmt instead of db).
What do you think @mkouba ?

@mkouba
Copy link
Contributor Author

mkouba commented May 4, 2021

I think this change should be mentioned in the migration guide (to use jdbc-cmt instead of db).
What do you think @mkouba ?

It's already there ;-). I added the note when this PR got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants