Move codestart test in integration-test module

[glefloch]

This branch moves tests from devtools-testing into integration-test/devtools.

This should fix Snapshot-ci job

[ia3andy]

@glefloch they had been moved on purpose, what is the problem?

[ia3andy]

I've added some fixes to those tests here, maybe that also fixes your problem:
#16692

[ia3andy]

FYI those tests have been moved there because they are also meant to be moved outside quarkus core when we move the tools out..

[aloubyansky]

@ia3andy do some tests in devtools rely on the quarkus-bom platform descriptor?

[glefloch]

@ia3andy, yes actually, those jobs fail:

• https://github.com/quarkusio/quarkus/actions/runs/772710466
• https://github.com/quarkusio/quarkus/actions/runs/772807870

with an error on resolving quarkus-bom:999-SNAPSHOT .

[aloubyansky]

The problem is that the nightly snapshot builds of the quarkus repo are failing now.

[ia3andy]

Then we need to think how to solve that problem, I don't think that moving those tests back there is the solution..

They should not need the bom, I will have a look on why they are using it..

[aloubyansky]

Now that I'm thinking about it, the registry client dev tools config utility that you moved to the devtools is pre-configured for the quarkus-bom platform. So we need a different platform for the devtools tests.

[glefloch]

It looks like the catalog is needed here:

quarkus/independent-projects/tools/devtools-testing/src/main/java/io/quarkus/devtools/testing/PlatformAwareTestBase.java

Line 34 in eb46690

catalog = QuarkusProjectHelper.getCatalogResolver().resolveExtensionCatalog();

which result with this error:

Caused by: io.quarkus.registry.RegistryResolutionException: Failed to resolve Quarkus extensions catalog io.quarkus:quarkus-bom-quarkus-platform-descriptor:json:999-SNAPSHOT:999-SNAPSHOT
5880
	at io.quarkus.registry.client.maven.MavenPlatformExtensionsResolver.resolvePlatformExtensions(MavenPlatformExtensionsResolver.java:47)
5881
	at io.quarkus.registry.client.RegistryClientDispatcher.resolvePlatformExtensions(RegistryClientDispatcher.java:34)
5882
	at io.quarkus.registry.RegistryExtensionResolver.resolvePlatformExtensions(RegistryExtensionResolver.java:90)
5883
	at io.quarkus.registry.ExtensionCatalogResolver.resolveExtensionCatalog(ExtensionCatalogResolver.java:299)
5884
	at io.quarkus.registry.ExtensionCatalogResolver.resolveExtensionCatalog(ExtensionCatalogResolver.java:254)
5885
	at io.quarkus.devtools.testing.PlatformAwareTestBase.getExtensionsCatalog(PlatformAwareTestBase.java:34)

[ia3andy]

It looks like the catalog is needed here:

quarkus/independent-projects/tools/devtools-testing/src/main/java/io/quarkus/devtools/testing/PlatformAwareTestBase.java

Line 34 in eb46690

catalog = QuarkusProjectHelper.getCatalogResolver().resolveExtensionCatalog();

which result with this error:

Caused by: io.quarkus.registry.RegistryResolutionException: Failed to resolve Quarkus extensions catalog io.quarkus:quarkus-bom-quarkus-platform-descriptor:json:999-SNAPSHOT:999-SNAPSHOT
5880
	at io.quarkus.registry.client.maven.MavenPlatformExtensionsResolver.resolvePlatformExtensions(MavenPlatformExtensionsResolver.java:47)
5881
	at io.quarkus.registry.client.RegistryClientDispatcher.resolvePlatformExtensions(RegistryClientDispatcher.java:34)
5882
	at io.quarkus.registry.RegistryExtensionResolver.resolvePlatformExtensions(RegistryExtensionResolver.java:90)
5883
	at io.quarkus.registry.ExtensionCatalogResolver.resolveExtensionCatalog(ExtensionCatalogResolver.java:299)
5884
	at io.quarkus.registry.ExtensionCatalogResolver.resolveExtensionCatalog(ExtensionCatalogResolver.java:254)
5885
	at io.quarkus.devtools.testing.PlatformAwareTestBase.getExtensionsCatalog(PlatformAwareTestBase.java:34)

Yes, I need to change it because in the end, it's not actually using the catalog..

[glefloch]

But as tests generate projects, doesn't codestart needs the catalog underneath ?

[ia3andy]

Not those, they only use the base codestarts which are also independent..

…

On Thu, Apr 22, 2021 at 12:12 PM Guillaume Le Floch < ***@***.***> wrote: But as tests generate projects, doesn't codestart needs the catalog underneath ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16715 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ664EIHYOHBG7G5FOKYMLTJ7ZCDANCNFSM43MAJK2Q> .

-- Andy Damevin

[glefloch]

So I revert this change and try to remove the catalog reference from the base test class?

[ia3andy]

@glefloch I am currently doing it no worries ;)

[glefloch]

OK, I close this one then. Thanks!

[ia3andy]

I added this commit 8ad17c9 (#16692) to fix this