Extension Codestarts are now "really" meant to start coding with an extension #16692

ia3andy · 2021-04-21T14:21:02Z

Change from --no-examples to --no-code in Create command for Maven Plugin and CLI
Change from --examples to --example in Create command for Maven Plugin and CLI (only one example can be selected at a time)
some example are moved to extension-codestarts and rewritten to be starters (almost no logic): funqy-http, resteasy-qute, picocli, config-yaml and resteasy, resteasy-reactive, spring-web
All singleton-example become example, only one can be activated for an app, they disable extension-codestarts
providesExample becomes providesCode in ExtensionProcessor
Remove resteasy-jackson and logging-json examples which are not really useful for now

THIS IS MEANT FOR 2.0 AS IT BREAKS COMPAT

Fixes #15997 (config-yaml is not using resteasy anymore, it just creates a GreetingConfig)

Generated code:

resteasy, resteasy-reactive and spring-web are not changed.

RESTEasy Qute

package org.acme;

import ...

@Path("/some-page")
public class SomePage {

    @Inject
    Template page;

    @GET
    @Produces(MediaType.TEXT_HTML)
    public TemplateInstance get(@QueryParam("name") String name) {
        return page.data("name", name);
    }

}

YAML Config

You have to bind it yourself somewhere to actually use it (command line, resteasy, resteasy-reactive)

package org.acme;

import ...

@ConfigProperties(prefix = "greeting")
public interface GreetingConfig {

    @ConfigProperty(name = "message")
    String message();

}

picocli

package org.acme;

import ...

@Command(name = "greeting", mixinStandardHelpOptions = true)
public class GreetingCommand implements Runnable {

    @Parameters(paramLabel = "<name>", defaultValue = "picocli",
        description = "Your name.")
    String name;

    @Override
    public void run() {
        System.out.printf("Hello %s, go go commando!\n", name);
    }

}

Funqy HTTP

package org.acme;

import io.quarkus.funqy.Funq;

public class MyFunctions {

    @Funq
    public String greeting(GreetingInput input) {
        return String.format("Hello %s!", input != null ? input.name : "Funqy");
    }


    public static class GreetingInput {
        public String name;
    }

}

FroMage · 2021-04-21T15:33:22Z

In the case of Qute, there's also the template file, right? In the case of YAML, there's also the YAML config file, right?

Otherwise, looks like the right move :)

ia3andy · 2021-04-21T15:36:52Z

In the case of Qute, there's also the template file, right? In the case of YAML, there's also the YAML config file, right?

Otherwise, looks like the right move :)

@FroMage

Yes and yes! :)

<!DOCTYPE html>
<html>
<head>
    <meta charset="UTF-8">
    <title>Hello {name ?: "Qute"}</title>
    <style>
        body {
            background-color: #000;
            color: #fff;
        }
        h1 {
            color: #4695EB;
            font-size: 6vw;
        }

        h1 b {
            color: #be9100;
        }

        p {
            font-size: 2vw;
        }
    </style>
</head>
<body>
<h1>Hello <b>{name ?: "Qute"}</b></h1>

<p>Create your web page using Quarkus RESTEasy & Qute</p>
</body>
</html>

and

greeting:
  message: "hello"

ia3andy · 2021-04-21T15:39:16Z

@FroMage

...-codestarts/src/test/java/io/quarkus/devtools/codestarts/quarkus/FunqyHttpCodestartTest.java

...cts/tools/devtools-testing/src/main/java/io/quarkus/devtools/testing/RegistryClientTest.java

ia3andy · 2021-04-22T13:53:05Z

...projects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/utils/NestedMaps.java

@@ -46,10 +46,22 @@ public static void deepMerge(Map left, Map right) {
                c.addAll((Collection) leftValue);
                c.addAll((Collection) rightValue);
                left.put(key, c);
-            } else {


@aloubyansky I found this nasty bug (from myself) while using a static codestart catalog from the tests 😱 the codestart catalog data was muted when generating a project (luckily in prod it's read at each generation).. This is not very optimized, at some point I will probably cache it. So better it be fixed :)

FYI in this deepMerge, it's ok to mutate left, but not right so I added some safety..

quarkus-bot · 2021-04-22T18:04:59Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `c8d3a8c`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

✖ io.quarkus.jdbc.mysql.deployment.DevServicesMySQLDatasourceTestCase.testDatasource - More details - Source on GitHub

quarkus-bot · 2021-04-22T21:40:30Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b632482`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.JandexMultiModuleProjectDevModeTest.main() line 21 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

✖ io.quarkus.jdbc.mysql.deployment.DevServicesMySQLDatasourceTestCase.testDatasource - More details - Source on GitHub

ia3andy · 2021-04-23T05:29:28Z

@gsmet each new rebase, I get some new CI errors... I think it's time to do another pass like we did a few months ago, it's been a while the CI haven't been stable.. wdyt?

…xtension

aloubyansky

I have some concerns using 999-SNAPSHOT in the tests that don't actually rely on the actual Quarkus version being built. It'd be good to change it to some unrelated version in a subsequent PR.

ia3andy changed the title ~~Pivot to extension codestarts instead of examples~~ Pivot to "extension codestarts" instead of "examples" Apr 21, 2021

ia3andy force-pushed the extension-codestarts branch from f6361c1 to 4780e55 Compare April 21, 2021 14:35

ia3andy changed the title ~~Pivot to "extension codestarts" instead of "examples"~~ Extension Codestarts are now "really" meant to start coding with an extension Apr 21, 2021

ia3andy force-pushed the extension-codestarts branch 2 times, most recently from 15f0f3c to 74a6857 Compare April 21, 2021 14:56

ia3andy force-pushed the extension-codestarts branch 7 times, most recently from 8a0ade6 to 392f012 Compare April 22, 2021 09:13

ia3andy mentioned this pull request Apr 22, 2021

Move codestart test in integration-test module #16715

Closed

ia3andy marked this pull request as ready for review April 22, 2021 12:19

ia3andy requested review from aloubyansky and glefloch April 22, 2021 12:19

ia3andy force-pushed the extension-codestarts branch from 8ad17c9 to 3655b97 Compare April 22, 2021 12:21

quarkusio deleted a comment from quarkus-bot bot Apr 22, 2021

glefloch reviewed Apr 22, 2021

View reviewed changes

...-codestarts/src/test/java/io/quarkus/devtools/codestarts/quarkus/FunqyHttpCodestartTest.java Show resolved Hide resolved

aloubyansky reviewed Apr 22, 2021

View reviewed changes

...cts/tools/devtools-testing/src/main/java/io/quarkus/devtools/testing/RegistryClientTest.java Show resolved Hide resolved

ia3andy force-pushed the extension-codestarts branch 2 times, most recently from 660da8a to c8d3a8c Compare April 22, 2021 13:50

ia3andy commented Apr 22, 2021

View reviewed changes

quarkusio deleted a comment from quarkus-bot bot Apr 22, 2021

ia3andy force-pushed the extension-codestarts branch from c8d3a8c to b632482 Compare April 22, 2021 18:15

ia3andy added 2 commits April 23, 2021 07:30

Extension Codestarts are now "really" meant to start coding with an e…

2711605

…xtension

Make devtools-testing test independent from platform

c635100

ia3andy force-pushed the extension-codestarts branch from b632482 to c635100 Compare April 23, 2021 05:30

aloubyansky approved these changes Apr 23, 2021

View reviewed changes

ia3andy merged commit e3fc195 into quarkusio:main Apr 23, 2021

ia3andy deleted the extension-codestarts branch April 23, 2021 09:29

quarkus-bot bot added this to the 2.0 - main milestone Apr 23, 2021

This was referenced Apr 23, 2021

Use fake version instead of 999-SNAPSHOT in devtools-testing #16758

Merged

Fix code.quarkus.io compatibility #16761

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extension Codestarts are now "really" meant to start coding with an extension #16692

Extension Codestarts are now "really" meant to start coding with an extension #16692

ia3andy commented Apr 21, 2021 •

edited

Loading

FroMage commented Apr 21, 2021

ia3andy commented Apr 21, 2021 •

edited

Loading

ia3andy commented Apr 21, 2021 •

edited

Loading

ia3andy Apr 22, 2021

ia3andy Apr 22, 2021

quarkus-bot bot commented Apr 22, 2021 •

edited

Loading

Failing Jobs - Building `c8d3a8c`

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

quarkus-bot bot commented Apr 22, 2021 •

edited

Loading

Failing Jobs - Building `b632482`

Test Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

ia3andy commented Apr 23, 2021

aloubyansky left a comment

Extension Codestarts are now "really" meant to start coding with an extension #16692

Extension Codestarts are now "really" meant to start coding with an extension #16692

Conversation

ia3andy commented Apr 21, 2021 • edited Loading

Generated code:

RESTEasy Qute

YAML Config

picocli

Funqy HTTP

FroMage commented Apr 21, 2021

ia3andy commented Apr 21, 2021 • edited Loading

ia3andy commented Apr 21, 2021 • edited Loading

ia3andy Apr 22, 2021

Choose a reason for hiding this comment

ia3andy Apr 22, 2021

Choose a reason for hiding this comment

quarkus-bot bot commented Apr 22, 2021 • edited Loading

Failing Jobs - Building c8d3a8c

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

quarkus-bot bot commented Apr 22, 2021 • edited Loading

Failing Jobs - Building b632482

Test Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

ia3andy commented Apr 23, 2021

aloubyansky left a comment

Choose a reason for hiding this comment

ia3andy commented Apr 21, 2021 •

edited

Loading

ia3andy commented Apr 21, 2021 •

edited

Loading

ia3andy commented Apr 21, 2021 •

edited

Loading

quarkus-bot bot commented Apr 22, 2021 •

edited

Loading

Failing Jobs - Building `c8d3a8c`

quarkus-bot bot commented Apr 22, 2021 •

edited

Loading

Failing Jobs - Building `b632482`