-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka, Schema Registry and Avro guide #16503
Kafka, Schema Registry and Avro guide #16503
Conversation
98d3cf1
to
5f4128e
Compare
corresponding quickstart: quarkusio/quarkus-quickstarts#832 |
@Ladicek maybe you'd also like to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I added a few minor comments, but nothing blocking.
I wanted to check whether we have documentation for Avro, so this is just in time! Too bad Apicurio Registry 2.x isn't out yet -- its Avro library is a little better (or maybe a lot better, I don't know). I'm adding support for that in #16473. |
5f4128e
to
f53668b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great! Thanks for writing this guide!
I've made a few suggestions.
f53668b
to
cd0d645
Compare
Don't forget to add the guide into the list of guides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good. I've added a few suggestions and a few comments.
|
||
== The infrastructure | ||
To use our application, we need Kafka and Apicurio Schema Registry. | ||
The easiest way to get them running is to use `docker-compose` to start the appropriate containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a tricky part... docker-compose
became docker compose
in the last docker version. I would keep it like this for now, but we may have to update (globally) the reference.
cd0d645
to
1c4f914
Compare
Before merging, add the guide to the guide list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to not forget to add the new guide into the list of guides.
|
Thanks! |
registry = new GenericContainer<>("apicurio/apicurio-registry-mem:1.2.2.Final") | ||
.withExposedPorts(8080) | ||
.withEnv("QUARKUS_PROFILE", "prod") | ||
.withEnv("KAFKA_BOOTSTRAP_SERVERS", kafka.getBootstrapServers()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the env vars KAFKA_BOOTSTRAP_SERVERS
, APPLICATION_ID
and APPLICATION_SERVER
are not required, the image apicurio/apicurio-registry-mem
stores the schemas in-memory and do not require access to kafka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'm updating the guide to use Apicurio Registry 2.0.0, so I'll remove this as part of the work.
No description provided.