Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka, Schema Registry and Avro guide #16503

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

michalszynkiewicz
Copy link
Member

No description provided.

@michalszynkiewicz
Copy link
Member Author

corresponding quickstart: quarkusio/quarkus-quickstarts#832

@michalszynkiewicz
Copy link
Member Author

@Ladicek maybe you'd also like to take a look?

Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I added a few minor comments, but nothing blocking.

docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
@Ladicek
Copy link
Contributor

Ladicek commented Apr 14, 2021

I wanted to check whether we have documentation for Avro, so this is just in time!

Too bad Apicurio Registry 2.x isn't out yet -- its Avro library is a little better (or maybe a lot better, I don't know). I'm adding support for that in #16473.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! Thanks for writing this guide!

I've made a few suggestions.

docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
@cescoffier
Copy link
Member

Don't forget to add the guide into the list of guides.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. I've added a few suggestions and a few comments.

docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved

== The infrastructure
To use our application, we need Kafka and Apicurio Schema Registry.
The easiest way to get them running is to use `docker-compose` to start the appropriate containers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a tricky part... docker-compose became docker compose in the last docker version. I would keep it like this for now, but we may have to update (globally) the reference.

docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kafka-schema-registry-avro.adoc Outdated Show resolved Hide resolved
@cescoffier
Copy link
Member

Before merging, add the guide to the guide list.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to not forget to add the new guide into the list of guides.

@michalszynkiewicz
Copy link
Member Author

Just to not forget to add the new guide into the list of guides.

quarkusio/quarkusio.github.io#962

@cescoffier cescoffier merged commit fb47fc1 into quarkusio:main Apr 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 16, 2021
@cescoffier
Copy link
Member

Thanks!

registry = new GenericContainer<>("apicurio/apicurio-registry-mem:1.2.2.Final")
.withExposedPorts(8080)
.withEnv("QUARKUS_PROFILE", "prod")
.withEnv("KAFKA_BOOTSTRAP_SERVERS", kafka.getBootstrapServers())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the env vars KAFKA_BOOTSTRAP_SERVERS , APPLICATION_ID and APPLICATION_SERVER are not required, the image apicurio/apicurio-registry-mem stores the schemas in-memory and do not require access to kafka

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'm updating the guide to use Apicurio Registry 2.0.0, so I'll remove this as part of the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants