Kafka, Schema Registry and Avro Quickstart #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalszynkiewicz
force-pushed
the
kafka-avro-schema-quickstart
branch
from
49dd817 to
75b7044
Compare
michalszynkiewicz
force-pushed
the
kafka-avro-schema-quickstart
branch
2 times, most recently
from
f76cbd2 to
64c1fac
Compare
cescoffier
requested changes
Apr 15, 2021
kafka-avro-schema-quickstart/src/main/resources/META-INF/resources/index.html
Outdated
Show resolved
Hide resolved
michalszynkiewicz
force-pushed
the
kafka-avro-schema-quickstart
branch
from
64c1fac to
c957c89
Compare
michalszynkiewicz
force-pushed
the
kafka-avro-schema-quickstart
branch
from
c957c89 to
621e5c5
Compare
cescoffier
approved these changes
Apr 16, 2021
famarting
reviewed
Apr 20, 2021
| registry = new GenericContainer<>("apicurio/apicurio-registry-mem:1.3.2.Final") | ||
| .withExposedPorts(8080) | ||
| .withEnv("QUARKUS_PROFILE", "prod") | ||
| .withEnv("KAFKA_BOOTSTRAP_SERVERS", kafka.getBootstrapServers()) |
There was a problem hiding this comment.
the env vars KAFKA_BOOTSTRAP_SERVERS , APPLICATION_ID and APPLICATION_SERVER are not required, the image apicurio/apicurio-registry-mem:1.3.2.Final stores the schemas in-memory and do not require access to kafka
There was a problem hiding this comment.
Good point. I'm updating the quickstart to use Apicurio Registry 2.0.0, so I'll remove this as part of the work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding guide: quarkusio/quarkus#16503
Check list:
Your pull request:
developmentbranch999-SNAPSHOTversion of Quarkusmvn clean test)mvn clean package -Pnative)mvn clean verify -Pnative)README.mdfile (with build and run instructions)pom.xmlandREADME.md