-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI - reduce the startup time #16320
Conversation
Before:
After:
|
how is it a problem for the CLI and not for your typical Quarkus applications? |
Well, it's not such a big problem but the generated We could probably initialize the set of removed beans lazily but I'm not sure it's worth it. |
I've removed |
- do not set CommandLine.setUsageHelpLongOptionsMaxWidth(); a side effect of this option is that picocli attempts to detect the terminal size which is quite expensive - removed @CommandLine.Command(usageHelpAutoWidth = true) from all commands - do not detect unused removed beans false posititives at runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me - i dont spot formatting differences either.
LGTM!
@patriot1burke might remember why he put the formatting widths in place - but in any case I think we should do everything we can do avoid relying on the expensive width call. |
effect of this option is that picocli attempts to detect the terminal
size which is quite expensive