-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make cli native #16043
Comments
It MUST be native. On my machine it took this time:
That's unacceptable for a CLI. |
This is what I have with native:
It's not amazingly fast tbh. I would have expected our command line support to be faster (especially to just display the help). But in any case, the real commands will do a lot more work and network accesses so they will be slow anyway. |
Being fast to show help isn't critical Imo. Try compare it to what same create commands using mvn and Gradle does. Then CLI jvm doesn't feel slow and the native startup time doesn't make a big difference. I thus still consider it nice/good to have not a must. |
I.e. if the option is between not releasing any cli vs having A jvm cli that is much faster than mvn/Gradle I would go for cli jvm. |
okey so now at keyboard to do runs on my machine: maven: jar direct: qs via jbang (expected some overhead but not that noticeable in create call) so 2.79s vs 5.38s and funny enough mvn felt faster as it was printing things out earlier - but thats subjective :) can it get improved ? probably - and I do actually think there must be something "too heavy" initialized. still think this is way better to have to avoid requiring mvn overhead. |
You can't possibly compare this to other JVM commands: everyone laments how slow they are to start. I do agree it's acceptable to start with a JVM version if we can't pull off a native one in time due to time constraints, but we should fix this and get something that bears comparison with other command-line apps (non-JVM). |
Still 5 times faster than the JVM version ;) |
100% agree - thats all I've been saying. lets look into it but dont make it the first priority. i/we spent ungawdly amount of time initailly on the cli as everyone seem insisting on it had to be native when windows native wasnt even possible; and I just dont want us to keep "hanging" on it being native as there are much more impactful things that keeps lagging. |
FTR with #16320 and native I get:
compared to:
I agree with Guillaume that most real commands will be slow anyway. However, I believe that we should really improve the startup time for simple commands because it just doesn't look good ;-). |
/cc @ebullient |
still relevant to explore; but its triaged right for now thus removing the need-triage label |
Description
can we make qs cli native ? does it make sense ?
The text was updated successfully, but these errors were encountered: