Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable live reload instrumentation by default #16297

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Disable live reload instrumentation by default #16297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/runtime/src/main/java/io/quarkus/runtime/LiveReloadConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
public class LiveReloadConfig {

/**
* Whether or not Quarkus should disable it's ability to not do a full restart
* Whether or not Quarkus should enable its ability to not do a full restart
* when changes to classes are compatible with JVM instrumentation.
*
* If this is set to false, Quarkus will always restart on changes and never perform class redefinition.
* If this is set to true, Quarkus will perform class redefinition when possible.
*/
@ConfigItem(defaultValue = "true")
@ConfigItem(defaultValue = "false")
boolean instrumentation;

/**
Expand Down
5 changes: 4 additions & 1 deletion integration-tests/maven/src/test/java/io/quarkus/maven/it/DevMojoIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,10 @@ public void testThatInstrumentationBasedReloadWorks() throws MavenInvocationExce
testDir = initProject("projects/classic-inst", "projects/project-intrumentation-reload");
runAndCheck();

//if there is an insturmentation based reload this will stay the same
// Enable instrumentation based reload to begin with
DevModeTestUtils.getHttpResponse("/app/enable");

//if there is an instrumentation based reload this will stay the same
String firstUuid = DevModeTestUtils.getHttpResponse("/app/uuid");

// Edit the "Hello" message.
Expand Down