-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable live reload instrumentation by default #16297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
force-pushed
the
instrumentation-disabled-default
branch
from
April 6, 2021 21:15
7ca4d45
to
75340fa
Compare
Failing Job Statuses
Test Failures⚙️ maven-linux-jdk11📦 integration-tests/maven# Tests: 122
+ Success: 118
- Failures: 1
- Errors: 0
! Skipped: 3 ❌
|
Looks good except for the failing test. I was thinking that if reload takes too long (maybe 1s? ) and instrumentation could have helped we could also log a message letter the user know that there may be a faster approach, but I am not sure if it is worth it or not. |
stuartwdouglas
approved these changes
Apr 6, 2021
@stuartwdouglas I think it's a good idea but I would make it something like 4 seconds. 1 second is perfectly fine when you're refreshing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stuartwdouglas per our discussion.
I think we should probably document it somewhere but couldn't find a good place for it (it's in the live reload config reference anyway).