Add support for opening the IDE from DevUI even if the default IDE script doesn't exist #16121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this on IntelliJ for both cases where |
geoand
changed the title
cuspymd
reviewed
Mar 31, 2021
Comment on lines
5
to
19
| final class IdeUtil { | ||
|
|
||
| private IdeUtil() { | ||
| } | ||
|
|
||
| static boolean isWindows() { | ||
| String os = System.getProperty("os.name"); | ||
| return os.toLowerCase(Locale.ENGLISH).startsWith("windows"); | ||
| } | ||
| } |
There was a problem hiding this comment.
isWindows() is currently used only in the "ide" package, but it seems not be dependent on only "ide". Isn't it better to change the class name to be more general? like 'SystemUtil' or 'PlatfromUtil'. And since the package '../deploy/util' already exists, wouldn't this class be better to be in it?
There was a problem hiding this comment.
Yes, if the need arises, I'll move it
phillip-kruger
approved these changes
Mar 31, 2021
core/deployment/src/main/java/io/quarkus/deployment/ide/Ide.java
Outdated
Show resolved
Hide resolved
…ript doesn't exist Currently support for this is only added for IntelliJ. Code is opened client side (via the URL handler it installs) so this support isn't needed, Netbeans already used something similar and Eclipse seems to be sort of problematic because we don't have a command which we can test that would not launch the IDE. Fixes: quarkusio#15721
phillip-kruger
approved these changes
Mar 31, 2021
geoand
added
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently support for this is only added for IntelliJ.
Code is opened client side (via the URL handler it installs)
so this support isn't needed, Netbeans already used something similar
and Eclipse seems to be sort of problematic because we don't have
a command which we can test that would not launch the IDE.
Furthermore this fallback is only tried if the default script does not exist
Fixes: #15721