Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI: open code in IDE should use IDE path from scanning processes #15721

Closed
FroMage opened this issue Mar 15, 2021 · 6 comments · Fixed by #16121
Closed

Dev UI: open code in IDE should use IDE path from scanning processes #15721

FroMage opened this issue Mar 15, 2021 · 6 comments · Fixed by #16121
Assignees
Labels
area/dev-ui kind/enhancement New feature or request
Milestone

Comments

@FroMage
Copy link
Member

FroMage commented Mar 15, 2021

ATM we scan the processes to find which IDE to use, but then we discard the running process command, and invoke idea or eclipse hoping it's in the user's $PATH, which turns out is not necessarily true, for people with multiple versions of each IDEs.

It would be nice if the scanning of processes returned the exact IDE command path and we used that instead of relying on $PATH.

CC @geoand

@FroMage FroMage added kind/enhancement New feature or request area/dev-ui labels Mar 15, 2021
@geoand
Copy link
Contributor

geoand commented Mar 15, 2021

This is a really good idea.

@FroMage FroMage assigned FroMage and unassigned FroMage Mar 15, 2021
@saumya1singh
Copy link
Contributor

Nice

@maxandersen
Copy link
Member

on first hand this does looks interesting but please be aware that wont work if using osx Applications. i.e. if you call the eclipse executable directly on osx it will launch a new instance, not reuse the existing already running eclipse.

I dont know if same goes for other IDE's, but I can very well imagine that there is a shell / batch wrapper to handle reusing logic thus using the command listed in process table is not a sure thing.

I would say it could be used if and only if no matching binary/script is found in the PATH.

@FroMage
Copy link
Member Author

FroMage commented Mar 15, 2021

I would say it could be used if and only if no matching binary/script is found in the PATH.

That's a great idea.

@geoand
Copy link
Contributor

geoand commented Mar 29, 2021

Is someone working on this or should I take it?

@saumya1singh
Copy link
Contributor

saumya1singh commented Mar 29, 2021

Is someone working on this or should I take it?

Sure,
These days, I am exploring Prod Stuff so not working on this :)

@geoand geoand self-assigned this Mar 29, 2021
geoand added a commit to geoand/quarkus that referenced this issue Mar 30, 2021
…ript doesn't exist

Currently support for this is only added for IntelliJ.
Code is opened client side (via the URL handler it installs)
so this support isn't needed, Netbeans already used something similar
and Eclipse seems to be sort of problematic because we don't have
a command which we can test that would not launch the IDE.

Fixes: quarkusio#15721
geoand added a commit to geoand/quarkus that referenced this issue Mar 30, 2021
…ript doesn't exist

Currently support for this is only added for IntelliJ.
Code is opened client side (via the URL handler it installs)
so this support isn't needed, Netbeans already used something similar
and Eclipse seems to be sort of problematic because we don't have
a command which we can test that would not launch the IDE.

Fixes: quarkusio#15721
geoand added a commit to geoand/quarkus that referenced this issue Mar 31, 2021
…ript doesn't exist

Currently support for this is only added for IntelliJ.
Code is opened client side (via the URL handler it installs)
so this support isn't needed, Netbeans already used something similar
and Eclipse seems to be sort of problematic because we don't have
a command which we can test that would not launch the IDE.

Fixes: quarkusio#15721
geoand added a commit to geoand/quarkus that referenced this issue Mar 31, 2021
…ript doesn't exist

Currently support for this is only added for IntelliJ.
Code is opened client side (via the URL handler it installs)
so this support isn't needed, Netbeans already used something similar
and Eclipse seems to be sort of problematic because we don't have
a command which we can test that would not launch the IDE.

Fixes: quarkusio#15721
phillip-kruger added a commit that referenced this issue Mar 31, 2021
Add support for opening the IDE from DevUI even if the default IDE script doesn't exist
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 31, 2021
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 3, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 3, 2021
…ript doesn't exist

Currently support for this is only added for IntelliJ.
Code is opened client side (via the URL handler it installs)
so this support isn't needed, Netbeans already used something similar
and Eclipse seems to be sort of problematic because we don't have
a command which we can test that would not launch the IDE.

Fixes: quarkusio#15721
(cherry picked from commit f15355f)
juazugas pushed a commit to juazugas/quarkus that referenced this issue Sep 30, 2021
…ript doesn't exist

Currently support for this is only added for IntelliJ.
Code is opened client side (via the URL handler it installs)
so this support isn't needed, Netbeans already used something similar
and Eclipse seems to be sort of problematic because we don't have
a command which we can test that would not launch the IDE.

Fixes: quarkusio#15721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-ui kind/enhancement New feature or request
Projects
None yet
5 participants