Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency gaps in container-image & k8s ITs #15974

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fix dependency gaps in container-image & k8s ITs #15974

merged 1 commit into from
Mar 24, 2021

Conversation

famod
Copy link
Member

@famod famod commented Mar 23, 2021 •
edited
Loading

Fixes #15946 (comment)

mvn validate -pl extensions/container-image/container-image-openshift/deployment -amd
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Quarkus - Container Image - OpenShift - Deployment                 [jar]
[INFO] Quarkus - Kubernetes - Openshift - Deployment                      [jar]
[INFO] Quarkus - Integration Tests - Kubernetes - Standard                [jar]
[INFO] Quarkus - Documentation                                            [jar]
[INFO]

That new enforcer.requiresMinimalDeploymentDependency.nonSuperfluous property is pretty verbose, but I wanted to make it clear where it belongs to.

/cc @geoand @iocanel @aloubyansky

famod
famod commented Mar 23, 2021
View reviewed changes
integration-tests/container-image/maven-invoker-way/pom.xml
@@ -22,6 +22,19 @@
</dependencies>
</dependencyManagement>
<dependencies>

<!-- made test scope only to force Maven to build these dependencies before running the tests-->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also: https://github.com/quarkusio/quarkus/blob/main/integration-tests/container-image/quarkus-standard-way/pom.xml#L21

geoand
geoand approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsmet gsmet merged commit 96c8f25 into quarkusio:main Mar 24, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 24, 2021
@famod famod deleted the fix-container-IT-deps branch March 24, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.
3 participants
@famod @geoand @gsmet