Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken kubernetes tests #15946

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Fix broken kubernetes tests #15946

merged 1 commit into from
Mar 23, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 23, 2021

It seems like with #15670 the tests were not updated but also CI didn't run them...

@geoand
Copy link
Contributor Author

geoand commented Mar 23, 2021

@famod looks like the tests in https://github.com/quarkusio/quarkus/tree/main/integration-tests/kubernetes/quarkus-standard-way were not run as part of #15670.

Any idea why?

@geoand geoand merged commit 3a8c2ea into quarkusio:main Mar 23, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 23, 2021
@geoand geoand deleted the broken-k8s-tests branch March 23, 2021 07:01
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.0.Final Mar 23, 2021
@famod
Copy link
Member

famod commented Mar 23, 2021

@geoand

$ mvn validate -pl extensions/container-image/container-image-openshift/deployment -amd
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Quarkus - Container Image - OpenShift - Deployment                 [jar]
[INFO] Quarkus - Kubernetes - Openshift - Deployment                      [jar]
[INFO] Quarkus - Documentation                                            [jar]
[INFO]

So it's not a GIB problem.
integration-tests/kubernetes/quarkus-standard-way is obviously missing some dependencies. I'll have a look later.

@geoand
Copy link
Contributor Author

geoand commented Mar 23, 2021

Cool, thanks

@famod
Copy link
Member

famod commented Mar 23, 2021

I must say I'm having a hard time to understand which of the container-image extensions are actually being tested (indirectly) by that IT module.
Just container-image-openshift?

@famod
Copy link
Member

famod commented Mar 23, 2021

@iocanel Can you help me out with this? ^

@iocanel
Copy link
Contributor

iocanel commented Mar 23, 2021

@famod: I'd say that all container image extensions are tested.

@famod
Copy link
Member

famod commented Mar 23, 2021

Thanks! Btw, maven-invoker-way has the same problem, AFAICS.

@famod
Copy link
Member

famod commented Mar 23, 2021

integration-tests\container-image is also affected (partially).

@geoand You've found a nice can of worms here. 😉

@geoand
Copy link
Contributor Author

geoand commented Mar 23, 2021

Let's hope it's easy to close :)

@famod
Copy link
Member

famod commented Mar 23, 2021

I'll have to teach that one enforcer rule a new trick to resolve this in a clean way (as far as "clean" can be streched with those minimal deployment dependencies... 😉).
So it's a bit more than just adding some xml entries.

@geoand
Copy link
Contributor Author

geoand commented Mar 23, 2021

Okay, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants