Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15545.
Fixes #15524.
Fixes #13666.
There are 3 distinct but simple enough enhancements/bug fixes so I've done a single PR instead of opening 3 PRs.
quarkus.oidc.authentication.cookie-path
to '/' and deprecatequarkus.oidc.authentication.restore-path-after-redirect
#15545cookie-path
is defaulted to/
- it has really should've been done earlier - so many users have lost a lot of time on finding it has to be done - it was not set originally because the very first case was about redirecting the user to the same original request URI so the cookies were not lost. It is actually already documented that the users should setcookie-path
to/
at least - but I guess the users would not always start from the docs :-)restore-path-after-redirect
is nowfalse
by default. Once I saw @danielpetisme's blog post I thought that was it, having the users to do:was not cool at all :-)
The only reason I've kept
restore-path-after-redirect
is because a very specific case is still tested, where, with even withredirect-path
the original request is still restored - the idea as far as I recall was to useredirect-path
just to meet the provider requirement that the sameredirect_uri
is used while still restoring the original URI at the endpoint level - not sure if anyone even depends on it - but for now it is safer to keep it;Note the original request URI is always restored anyway if no
redirect-path
is setoidc and oidc-client have the same configuration exception when the required properties are missing #15524 - better exception messages to distinguish between oidc/oidc-client config errors (more work may be needed later on - just a start)
Add
OidcConfigurationMetadata
injectable request-scoped bean #13666 - @danielpetisme has asked for it - it is easy to do so I've just added a producer and a test