Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default quarkus.oidc.authentication.cookie-path to '/' and deprecate quarkus.oidc.authentication.restore-path-after-redirect #15545

Closed
sberyozkin opened this issue Mar 8, 2021 · 1 comment · Fixed by #15639
Assignees
Milestone

Comments

@sberyozkin
Copy link
Member

Description
We can optimize on 2 properties:

quarkus.oidc.authentication.cookie-path=/
quarkus.oidc.authentication.redirect-path=/callback
quarkus.oidc.authentication.restore-path-after-redirect=false

quarkus.oidc.authentication.cookie-path=/ should be default as the users will likely spend some time first figuring out why the authentication is failing - due to a missing state cookie for ex and then having to set it to /.

and

quarkus.oidc.authentication.restore-path-after-redirect is simply redundant - if quarkus.oidc.authentication.redirect-path is set then the user will have to be returned to this path and if it is not set then the current request URI has to be restored.

CC @danielpetisme

@sberyozkin sberyozkin self-assigned this Mar 8, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 8, 2021

/cc @pedroigor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant