Small path fix for the dev ui #15529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Phillip Kruger <[email protected]>
gsmet
approved these changes
Mar 8, 2021
phillip-kruger
added
the
triage/waiting-for-ci
|
Will double check w/ some tests -- but trimming/munging the path like this isn't quite right (even if it cosmetically does the job). We should have opened the follow-on item for the dev console as soon as we finished #15030 .. |
|
This particular fix only fixed some of the paths.. and the other path value (httpRootPath) right next to it, still ended in a slash. |
|
Yea I can apply it to |
|
I have a PR in flight w/ Stuart.. as what you fixed here will break a few of the other URLs that didn't include the slash.. (and it's not quite the right fix. Will ask you to review. ;) |
This was referenced Mar 12, 2021
Merged
This was referenced Mar 12, 2021
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the /q path changes introduces in 1.12.1 the UI contains an extra / , so the references to the static content would be
/q//dev.Even though it still works, this fix the path to be correct.
Signed-off-by:Phillip Kruger [email protected]