Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpRootPathBuildItem has changed his path format several times. #15535

Closed
pjgg opened this issue Mar 8, 2021 · 3 comments · Fixed by #15558
Closed

HttpRootPathBuildItem has changed his path format several times. #15535

pjgg opened this issue Mar 8, 2021 · 3 comments · Fixed by #15558
Labels
kind/bug Something isn't working
Milestone

Comments

@pjgg
Copy link
Contributor

pjgg commented Mar 8, 2021

Describe the bug

On version 1.11.1.Final or 1.12.0.Final HttpRootPathBuildItem returns a path like http://test-http-advanced-pablo-http-advanced.apps.ocp46.dynamic.quarkus/api but on version 1.11.5.Final or 1.12.1.Final HttpRootPathBuildItem returns a path like http://test-http-advanced-pablo-http-advanced.apps.ocp46.dynamic.quarkus/api/

note that on version 1.11.5.Final the paths end with "/".

I am not sure if these inconsistencies are related to this commit: e0f8ec9

I think that should not end with "/" at the end.

Could you clarify the expected behavior?

@pjgg pjgg added the kind/bug Something isn't working label Mar 8, 2021
@gsmet
Copy link
Member

gsmet commented Mar 8, 2021

@ebullient @kenfinnigan

FWIW this led to PR like this: #15529

@ebullient
Copy link
Member

ebullient commented Mar 8, 2021

Yes. We know. @stuartwdouglas mentioned the cosmetic fix needed for the dev ui.

@gsmet -- Have you pushed publish on the blog post yet?
@pjgg were the Javadoc comments on the build item clear? (they were updated in 1.12.1.Final & 1.11.5.Final)

The blog post PR (that does at least explain the why) is here: quarkusio/quarkusio.github.io#915

@pjgg, you should be thinking of anything that needs to be "served from" either the HttpRoot or the NonApplicationEndpoint root path as relative resources (in the pure HTTP URL sense).. Vert.x likes to train people to add their own leading slashes to things, and that is specifically what you can't do anymore in quarkus. You need to construct paths that are relative to whatever the containing route should be.

@ebullient
Copy link
Member

Also, I think I need to go back though #15529 -- while it did resolve the cosmetic issue re: having two slashes visible, I'm not sure it did it in the correct way that would ensure paths are resolved correctly as config allows things to be moved around (w/o being misinterpreted).

@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 10, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.2.Final Mar 10, 2021
This was referenced Mar 12, 2021
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants