-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpRootPathBuildItem has changed his path
format several times.
#15535
Comments
FWIW this led to PR like this: #15529 |
Yes. We know. @stuartwdouglas mentioned the cosmetic fix needed for the dev ui. @gsmet -- Have you pushed publish on the blog post yet? The blog post PR (that does at least explain the why) is here: quarkusio/quarkusio.github.io#915 @pjgg, you should be thinking of anything that needs to be "served from" either the HttpRoot or the NonApplicationEndpoint root path as relative resources (in the pure HTTP URL sense).. Vert.x likes to train people to add their own leading slashes to things, and that is specifically what you can't do anymore in quarkus. You need to construct paths that are relative to whatever the containing route should be. |
Also, I think I need to go back though #15529 -- while it did resolve the cosmetic issue re: having two slashes visible, I'm not sure it did it in the correct way that would ensure paths are resolved correctly as config allows things to be moved around (w/o being misinterpreted). |
Describe the bug
On version 1.11.1.Final or 1.12.0.Final
HttpRootPathBuildItem
returns a path likehttp://test-http-advanced-pablo-http-advanced.apps.ocp46.dynamic.quarkus/api
but on version 1.11.5.Final or 1.12.1.FinalHttpRootPathBuildItem
returns a path likehttp://test-http-advanced-pablo-http-advanced.apps.ocp46.dynamic.quarkus/api/
note that on version 1.11.5.Final the paths end with "/".
I am not sure if these inconsistencies are related to this commit: e0f8ec9
I think that should not end with "/" at the end.
Could you clarify the expected behavior?
The text was updated successfully, but these errors were encountered: