-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LocalDate as Path-/QueryParam #15451
Conversation
Thanks for this! I just now (sorry about that...) realized that using such parameter converters causes a performance penalty, which in this case we can avoid - but it requires a deeper integration into Quarkus. |
@geoand |
Sure, I'll try to write so pointers over the weekend |
Here is what needs to be done at a high lever: Add a similar check like is done at: where you will check to see if the type is That should be enough to get the |
@geoand Do you have a good template for the unit tests? And where should the tests be placed? I think it makes sense to test at least the following scenarios:
|
The code seems reasonable. As for the test, just add an something in https://github.com/quarkusio/quarkus/tree/c3458c623b30656ba435cb5dfdeda039aa09e4ec/extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment/src/test/java/io/quarkus/resteasy/reactive/server/test/simple |
Also, when you are done, please squash the commits |
@geoand Regarding Native: Squashed the commits locally and force-pushed. Is this okay? Anything left? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot!
closes #5860