Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resteasy-Reactive: Add LocalDate-Support for Form Parameters #21361

Closed
fwippe opened this issue Nov 11, 2021 · 3 comments · Fixed by #21373
Closed

Resteasy-Reactive: Add LocalDate-Support for Form Parameters #21361

fwippe opened this issue Nov 11, 2021 · 3 comments · Fixed by #21373
Labels
area/rest kind/enhancement New feature or request
Milestone
2.5.0.Final

Comments

@fwippe
Copy link
Contributor

fwippe commented Nov 11, 2021

Description

Pull request #15451 (via bug #5860) introduced LocalDate support for RESTeasy parameters of type Query and Path. IMHO there is really no compelling reason not to support parameters of type Form as well.

I hereby request the feature to support automatic LocalDate conversion of Form parameters and volunteer for a corresponding pull request. What do you think?

Implementation ideas

Extend type test in extractParameterInfo
@fwippe fwippe added the kind/enhancement New feature or request label Nov 11, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 11, 2021

/cc @FroMage, @geoand, @stuartwdouglas

@geoand
Copy link
Contributor

geoand commented Nov 11, 2021

Sounds reasonable to me. Would you like to try to add this feature?

@fwippe
Copy link
Contributor Author

fwippe commented Nov 11, 2021

Sure, I'll give it a try

@fwippe fwippe mentioned this issue Nov 11, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 11, 2021
@gsmet gsmet modified the milestones: 2.6 - main, 2.5.0.Final Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/rest kind/enhancement New feature or request
Projects
None yet
Milestone
2.5.0.Final
Development

Successfully merging a pull request may close this issue.

Resteasy-Reactive: Add LocalDate-Support for Form Parameters fwippe/quarkus
3 participants
@gsmet @geoand @fwippe