Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-coverage problem in ConfigInstantiator & add jacoco to dependabot #15315

Merged
merged 1 commit into from
Feb 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ updates:
- dependency-name: org.mockito:*
- dependency-name: org.awaitility:awaitility
- dependency-name: com.thoughtworks.xstream:xstream
- dependency-name: org.jacoco:*
# Maven plugins
- dependency-name: net.revelc.code.formatter:formatter-maven-plugin
- dependency-name: net.revelc.code:impsort-maven-plugin
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ then change into the `coverage-report` directory and run `mvn package`. The code
This currently does not work on Windows as it uses a shell script to copy all the classes and files into the code coverage
module.

If you just need a report for a single module, run `mvn install jacoco:report -Ptest-coverage` in that module (or with `-f ...`).

## Extensions

### Descriptions
Expand Down
3 changes: 2 additions & 1 deletion build-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@

<!-- Code Coverage Properties-->
<jacoco.agent.argLine></jacoco.agent.argLine>
<jacoco.version>0.8.5</jacoco.version>
<!-- Note: this version is also set in quarkus-bom but BOMs don't contribute to pluginManagement or properties -->
<jacoco.version>0.8.6</jacoco.version>

<maven-dependency-plugin.version>3.1.2</maven-dependency-plugin.version>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ private static void handleObject(String prefix, Object o, SmallRyeConfig config)
return;
}
for (Field field : cls.getDeclaredFields()) {
if (Modifier.isFinal(field.getModifiers())) {
if (field.isSynthetic() || Modifier.isFinal(field.getModifiers())) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue;
}
field.setAccessible(true);
Expand Down