Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test-coverage problem in ConfigInstantiator & add jacoco to dependabot #15315

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix test-coverage problem in ConfigInstantiator & add jacoco to dependabot #15315

merged 1 commit into from
Feb 25, 2021

Conversation

famod
Copy link
Member

@famod famod commented Feb 24, 2021 •
edited
Loading

Fixes #15300

@quarkus-bot quarkus-bot bot added area/config area/core area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Feb 24, 2021
@famod
Copy link
Member Author

famod commented Feb 24, 2021

In draft mode for now because there are some more prioritized PRs.

famod
famod commented Feb 24, 2021
View reviewed changes
core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigInstantiator.java
@@ -65,7 +65,7 @@ private static void handleObject(String prefix, Object o, SmallRyeConfig config)
return;
}
for (Field field : cls.getDeclaredFields()) {
if (Modifier.isFinal(field.getModifiers())) {
if (field.isSynthetic() || Modifier.isFinal(field.getModifiers())) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15300 (comment)

@famod famod marked this pull request as ready for review February 25, 2021 09:04
@adutra adutra mentioned this pull request Feb 25, 2021
Open
gastaldi
gastaldi approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gsmet
gsmet approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @famod!

@gsmet gsmet merged commit fbd05fe into quarkusio:master Feb 25, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 25, 2021
@famod famod deleted the jacoco-fixes branch February 25, 2021 15:22
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.1.Final Mar 1, 2021
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/config area/core area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
1.12.1.Final
Development

Successfully merging this pull request may close these issues.

Test coverage profile doesn't work
3 participants
@famod @gastaldi @gsmet