Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uberJar Maven/Gradle param & quarkus.package.uber-jar property #14987

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Remove uberJar Maven/Gradle param & quarkus.package.uber-jar property #14987

merged 1 commit into from
Feb 11, 2021

Conversation

famod
Copy link
Member

@famod famod commented Feb 10, 2021

Resolves #14878

/cc @glefloch

@aloubyansky Not sure what to do with QuarkusBootstrapMojo.ignoredEntries. It says:

When using the uberJar option, this array specifies entries that should be excluded from the final jar.

but looking at the usage, it seems it's always evaluated, not only for uber-jar?

@aloubyansky
Copy link
Member

We should probably keep handling QuarkusBootstrapMojo.ignoredEntries as we do currently.

@famod
Copy link
Member Author

famod commented Feb 11, 2021

@aloubyansky Alright, I'll revise the JavaDoc a bit then.

@gsmet gsmet merged commit e23ef47 into quarkusio:master Feb 11, 2021
@ghost ghost added this to the 1.13 - master milestone Feb 11, 2021
@gsmet
Copy link
Member

gsmet commented Feb 11, 2021

Thanks for the cleanup!

@famod famod deleted the remove-uberJar-param branch February 11, 2021 17:10
@famod
Copy link
Member Author

famod commented Feb 11, 2021

@gsmet I'll add something to the Migration Guide for this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove uberJar parameter from Maven mojos/goals in 1.13
4 participants